From: Takashi Iwai <tiwai@suse.de>
To: "Jie, Yang" <yang.jie@intel.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"broonie@kernel.org" <broonie@kernel.org>,
"tanu.kaskinen@linux.intel.com" <tanu.kaskinen@linux.intel.com>,
"Girdwood, Liam R" <liam.r.girdwood@intel.com>
Subject: Re: [PATCH v9 0/7] ALSA: jack: Refactoring for jack kctls
Date: Thu, 23 Apr 2015 17:00:18 +0200 [thread overview]
Message-ID: <s5hmw1ykhz1.wl-tiwai@suse.de> (raw)
In-Reply-To: <E7B1D079BA13FB44A978CC8F69C7D6A90551F692@SHSMSX101.ccr.corp.intel.com>
At Thu, 23 Apr 2015 13:45:07 +0000,
Jie, Yang wrote:
> >
> > - Fix typos and syntax errors in comments and descriptions.
> > A spell checker is your friend.
>
> I just download one from git://github.com/mprpic/git-spell-check.git,
> now learning to use it, do you have better suggestion?
Any spell checker would be fine. I don't know of this tool, but isn't
it only for XML?
Also, for a lengthy document like in the last patch, it'd be good to
get it proof read once by some native English speakers. I remember a
guy living in a corner of British Islands in your team ;)
Last but not least, reading twice before submission is always an old
good method to catch silly typos or errors. (I forget this often,
too.)
Takashi
next prev parent reply other threads:[~2015-04-23 15:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-23 2:32 [PATCH v9 0/7] ALSA: jack: Refactoring for jack kctls Jie Yang
2015-04-23 2:32 ` [PATCH v9 1/7] ALSA: jack: implement kctl creating for jack device Jie Yang
2015-04-23 2:32 ` [PATCH v9 2/7] ALSA: Jack: handle jack embedded kcontrol creating within ctljack Jie Yang
2015-04-23 2:32 ` [PATCH v9 3/7] ALSA: jack: extend snd_jack_new to support phantom jack Jie Yang
2015-04-23 2:32 ` [PATCH v9 4/7] ALSA: hda - Update to use the new jack kctls method Jie Yang
2015-04-23 2:32 ` [PATCH v9 5/7] ASoC: jack: create kctls according to jack pins info Jie Yang
2015-04-27 19:33 ` Mark Brown
2015-04-23 2:32 ` [PATCH v9 6/7] ALSA: jack: remove exporting ctljack functions Jie Yang
2015-04-23 2:32 ` [PATCH v9 7/7] ALSA: Docs: Add documentation for Jack kcontrols Jie Yang
2015-04-23 12:47 ` [PATCH v9 0/7] ALSA: jack: Refactoring for jack kctls Takashi Iwai
2015-04-23 13:45 ` Jie, Yang
2015-04-23 15:00 ` Takashi Iwai [this message]
2015-04-23 15:20 ` Liam Girdwood
2015-04-24 4:27 ` Jie, Yang
2015-04-23 18:18 ` Mark Brown
2015-04-24 4:37 ` Jie, Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hmw1ykhz1.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=liam.r.girdwood@intel.com \
--cc=tanu.kaskinen@linux.intel.com \
--cc=yang.jie@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox