From: Takashi Iwai <tiwai@suse.de>
To: Daniel Mack <zonque@gmail.com>
Cc: blablack@gmail.com, alsa-devel@alsa-project.org,
clemens@ladisch.de, gdiffey@gmail.com, linuxaudio@showlabor.de
Subject: Re: [PATCH 2/5] ALSA: snd-usb: implement new endpoint streaming model
Date: Tue, 20 Dec 2011 16:08:52 +0100 [thread overview]
Message-ID: <s5hmxangu0r.wl%tiwai@suse.de> (raw)
In-Reply-To: <1324374520-32332-3-git-send-email-zonque@gmail.com>
At Tue, 20 Dec 2011 10:48:37 +0100,
Daniel Mack wrote:
>
> In order to split changes properly, this patch only adds the new
> implementation but leaves the old one around, so the the driver doesn't
> change its behaviour. The switch to actually use the new code is
> submitted separately.
>
> Signed-off-by: Daniel Mack <zonque@gmail.com>
One point I'm not sure about this implementation is the use of
tasklet. The tasklet itself runs again in ep->lock, what's the
rationale for it? In other words, can't it be a straight function
call?
I would understand if it were a workqueue and running in the
schedulable context. But, I see no big merit of tasklet here.
(And tasklet is a candidate to be dropped sometime in future.)
Maybe I'm missing something behind it...
thanks,
Takashi
next prev parent reply other threads:[~2011-12-20 15:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-20 9:48 [PATCH 0/5] snd-usb endpoint rework, take 4 Daniel Mack
2011-12-20 9:48 ` [PATCH 1/5] ALSA: snd-usb: add snd_usb_audio-wide mutex Daniel Mack
2011-12-20 9:48 ` [PATCH 2/5] ALSA: snd-usb: implement new endpoint streaming model Daniel Mack
2011-12-20 15:08 ` Takashi Iwai [this message]
2011-12-20 15:32 ` Clemens Ladisch
2011-12-20 20:16 ` Daniel Mack
2011-12-20 15:42 ` Takashi Iwai
2011-12-20 20:08 ` Daniel Mack
2011-12-20 9:48 ` [PATCH 3/5] ALSA: snd-usb: switch over to new endpoint streaming logic Daniel Mack
2011-12-20 9:48 ` [PATCH 4/5] ALSA: snd-usb: remove old " Daniel Mack
2011-12-20 9:48 ` [PATCH 5/5] ALSA: snd-usb: add support for implicit feedback Daniel Mack
-- strict thread matches above, loose matches on Subject: below --
2011-12-20 23:34 [PATCH 0/5] snd-usb endpoint rework, take 5 Daniel Mack
2011-12-20 23:34 ` [PATCH 2/5] ALSA: snd-usb: implement new endpoint streaming model Daniel Mack
2011-12-21 16:16 ` Aurélien Leblond
2011-12-21 16:34 ` Daniel Mack
2011-12-21 17:11 ` Aurélien Leblond
2011-12-21 17:18 ` Daniel Mack
2011-12-22 17:55 ` Aurélien Leblond
2011-12-22 19:04 ` Daniel Mack
2011-12-18 23:02 [PATCH 0/5] snd-usb endpoint logic rework, version 3 Daniel Mack
2011-12-18 23:02 ` [PATCH 2/5] ALSA: snd-usb: implement new endpoint streaming model Daniel Mack
2011-11-18 20:05 [PATCH 0/5] RFC v2 for snd-usb endpoint logic rework Daniel Mack
2011-11-18 20:05 ` [PATCH 2/5] ALSA: snd-usb: implement new endpoint streaming model Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hmxangu0r.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=blablack@gmail.com \
--cc=clemens@ladisch.de \
--cc=gdiffey@gmail.com \
--cc=linuxaudio@showlabor.de \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).