From: Takashi Iwai <tiwai@suse.de>
To: Paul Davis <paul@linuxaudiosystems.com>
Cc: "John S. Denker" <jsd@monmouth.com>, alsa-devel@lists.sourceforge.net
Subject: Re: patch for hammerfall driver
Date: Tue, 04 Feb 2003 12:10:04 +0100 [thread overview]
Message-ID: <s5hn0lcgv3n.wl@alsa2.suse.de> (raw)
In-Reply-To: <E18fhrT-0007US-00@sc8-sf-list1.sourceforge.net>
At Mon, 03 Feb 2003 09:49:59 -0500,
Paul Davis wrote:
>
> >> To be explicit: whenever you see a bug, don't just
> >> ask how to fix this instance of the bug; ask what
> >> it would take to make sure no bug of this ilk ever
> >> occurs again.
> >>
> >> In this case:
> >> a) It would help to have some comments in the code
> >> saying where the constants are coming from, so that
> >> misconceptions can be more easily spotted.
> >> b) It would help to use correctly computed constants
> >> such as
>
> actually, neither would have really helped very much here. i don't
> know who set the values to those that were here before. the values
> were clearly wrong on any reading of the code, and i've thought about
> them on previous readings. the values that were there before were not
> "buggy" - they were completely wrong.
i also don't know how they got in, but at least the values were
already there more than one year ago...
Takashi
-------------------------------------------------------
This SF.NET email is sponsored by:
SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See!
http://www.vasoftware.com
prev parent reply other threads:[~2003-02-04 11:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-02 21:37 patch for hammerfall driver Paul Davis
2003-02-03 9:57 ` Takashi Iwai
[not found] ` <3E3E6079.2050905@monmouth.com>
2003-02-03 12:40 ` Takashi Iwai
2003-02-03 14:49 ` Paul Davis
2003-02-04 11:10 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hn0lcgv3n.wl@alsa2.suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@lists.sourceforge.net \
--cc=jsd@monmouth.com \
--cc=paul@linuxaudiosystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox