From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3410C54FC9 for ; Tue, 21 Apr 2020 19:41:33 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4F080206D5 for ; Tue, 21 Apr 2020 19:41:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="GBi/wVBD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4F080206D5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id AABF516BA; Tue, 21 Apr 2020 21:40:41 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz AABF516BA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1587498091; bh=og/S6+5IXkPfpKJabhbNHV5eu9OyHUtBudD2OrkTejU=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=GBi/wVBDsOpnjHqC571TVknOCNqFAsk/Pr8XTKmr4nCasxwmvqiskAjZNkkUInFWx AqzfgYSXHHgD+AzpBbxT3iIpYgg/7nlwcMAnL3/qfD2L6feFrRHfYakSNv4brlfn4z 0Cae4R5pz4is13BkwdndXLaYCwRO+Mf5bs7Z73eA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 0FAB7F800E7; Tue, 21 Apr 2020 21:40:41 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7C66EF801EC; Tue, 21 Apr 2020 21:40:39 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 2115DF800E7 for ; Tue, 21 Apr 2020 21:40:32 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 2115DF800E7 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 0C86EAE28; Tue, 21 Apr 2020 19:40:31 +0000 (UTC) Date: Tue, 21 Apr 2020 21:40:30 +0200 Message-ID: From: Takashi Iwai To: "Alex Xu (Hello71)" Subject: Re: Unrecoverable AER error when resuming from RAM (hda regression in 5.7-rc2) In-Reply-To: <1587494585.7pihgq0z3i.none@localhost> References: <1587494585.7pihgq0z3i.none.ref@localhost> <1587494585.7pihgq0z3i.none@localhost> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: linux-pci@vger.kernel.org, alsa-devel@alsa-project.org, Roy Spliet , linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 21 Apr 2020 21:08:44 +0200, Alex Xu (Hello71) wrote: > > With 5.7-rc2, after resuming from suspend to RAM, I get: > > [ 55.679382] pcieport 0000:00:03.1: AER: Multiple Uncorrected (Non-Fatal) error received: 0000:00:00.0 > [ 55.679405] pcieport 0000:00:03.1: AER: PCIe Bus Error: severity=Uncorrected (Non-Fatal), type=Transaction Layer, (Requester ID) > [ 55.679410] pcieport 0000:00:03.1: AER: device [1022:1453] error status/mask=00100000/04400000 > [ 55.679414] pcieport 0000:00:03.1: AER: [20] UnsupReq (First) > [ 55.679417] pcieport 0000:00:03.1: AER: TLP Header: 40000004 0a0000ff fffc0e80 00000000 > [ 55.679423] amdgpu 0000:0a:00.0: AER: can't recover (no error_detected callback) > [ 55.679425] snd_hda_intel 0000:0a:00.1: AER: can't recover (no error_detected callback) > [ 55.679455] pcieport 0000:00:03.1: AER: device recovery failed > > Then the display freezes and the system basically falls apart (can't > even sudo reboot -f, need to use magic sysrq). > > I bisected this to "ALSA: hda: Skip controller resume if not needed". > Setting snd_hda_intel.power_save=0 resolves the issue. Hrm, it means the condition to skip the controller resume doesn't fit well. Does the patch below help? But looking at the dmesg output: > [ 1.021452] snd_hda_codec_generic hdaudioC0D0: ignore pin 0x7, too many assigned pins > [ 1.021461] snd_hda_codec_generic hdaudioC0D0: ignore pin 0x9, too many assigned pins > [ 1.021471] snd_hda_codec_generic hdaudioC0D0: ignore pin 0xb, too many assigned pins > [ 1.021480] snd_hda_codec_generic hdaudioC0D0: ignore pin 0xd, too many assigned pins > [ 1.021482] snd_hda_codec_generic hdaudioC0D0: autoconfig for Generic: line_outs=0 (0x0/0x0/0x0/0x0/0x0) type:line > [ 1.021482] snd_hda_codec_generic hdaudioC0D0: speaker_outs=0 (0x0/0x0/0x0/0x0/0x0) > [ 1.021483] snd_hda_codec_generic hdaudioC0D0: hp_outs=0 (0x0/0x0/0x0/0x0/0x0) > [ 1.021484] snd_hda_codec_generic hdaudioC0D0: mono: mono_out=0x0 > [ 1.021484] snd_hda_codec_generic hdaudioC0D0: dig-out=0x3/0x5 > [ 1.021485] snd_hda_codec_generic hdaudioC0D0: inputs: ... it looks like snd-hda-codec-generic is used for HDMI/DP codec. This can't work well. Did you enable CONFIG_SND_HDA_HDMI? In anyway, please give alsa-info.sh output. Run the script with --no-upload option and attach the output. thanks, Takashi --- --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -1060,7 +1060,7 @@ static int azx_resume(struct device *dev) /* check for the forced resume */ list_for_each_codec(codec, &chip->bus) { - if (hda_codec_need_resume(codec)) { + if (!codec->relaxed_resume) { forced_resume = true; break; }