From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF7EDC432C3 for ; Thu, 14 Nov 2019 10:58:45 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 652B42070E for ; Thu, 14 Nov 2019 10:58:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="rX5F1B3+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 652B42070E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 937AE847; Thu, 14 Nov 2019 11:57:53 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 937AE847 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1573729123; bh=tPNr66l1MBbW8fsL7na8W175XV16mpyH16nFR+cPf1U=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=rX5F1B3+MFfPzKreXG1d7GC4042LFOMgwviwmslObdtH6rdAkOodS+uNEhZ6LW37j Yncfi4/w3qjUMJMJSrBj9R21rPPkHSfQVLQFKi1Se8IIq4i637TdtDI/28H103WLLB dDBSkyhaVmnJL2mTj+EOlzFxsEkO/D5v0JgQU/1U= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2EA80F800CD; Thu, 14 Nov 2019 11:57:53 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 20F36F800CF; Thu, 14 Nov 2019 11:57:52 +0100 (CET) Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A2BCFF80084 for ; Thu, 14 Nov 2019 11:57:49 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A2BCFF80084 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id C0D83AD00; Thu, 14 Nov 2019 10:57:48 +0000 (UTC) Date: Thu, 14 Nov 2019 11:57:48 +0100 Message-ID: From: Takashi Iwai To: Nikhil Mahale In-Reply-To: <20191114033704.18171-4-nmahale@nvidia.com> References: <20191114033704.18171-1-nmahale@nvidia.com> <20191114033704.18171-4-nmahale@nvidia.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Cc: alsa-devel@alsa-project.org, tiwai@suse.com, aplattner@nvidia.com Subject: Re: [alsa-devel] [PATCH v1 3/5] ALSA: hda - Add DP-MST conn list support X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 14 Nov 2019 04:37:02 +0100, Nikhil Mahale wrote: > > Document change notification HDA040-A for the Intel High Definition > Audio 1.0a specification introduces a Device Select verb for Digital > Display Pin Widgets that are multi-stream capable. This verb selects > a Device Entry that is used by subsequent Pin Widget verbs, > including the Get Connection List Entry verb. > > This patch queries the current Device Select value, associates it > with the connection list, and updates the connection list management > code to consider dev_id along with nid. I don't get why this is needed. This is the list that is added only from snd_hda_override_conn_list(), and you don't change that call pattern, so dev_id is always zero. thanks, Takashi > > Signed-off-by: Nikhil Mahale > Reviewed-by: Aaron Plattner > --- > sound/pci/hda/hda_codec.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c > index a2fb19129219..8f32cab8f4a4 100644 > --- a/sound/pci/hda/hda_codec.c > +++ b/sound/pci/hda/hda_codec.c > @@ -88,6 +88,7 @@ struct hda_conn_list { > struct list_head list; > int len; > hda_nid_t nid; > + int dev_id; > hda_nid_t conns[0]; > }; > > @@ -96,8 +97,9 @@ static struct hda_conn_list * > lookup_conn_list(struct hda_codec *codec, hda_nid_t nid) > { > struct hda_conn_list *p; > + int dev_id = snd_hda_get_dev_select(codec, nid); > list_for_each_entry(p, &codec->conn_list, list) { > - if (p->nid == nid) > + if (p->nid == nid && p->dev_id == dev_id) > return p; > } > return NULL; > @@ -113,6 +115,7 @@ static int add_conn_list(struct hda_codec *codec, hda_nid_t nid, int len, > return -ENOMEM; > p->len = len; > p->nid = nid; > + p->dev_id = snd_hda_get_dev_select(codec, nid); > memcpy(p->conns, list, len * sizeof(hda_nid_t)); > list_add(&p->list, &codec->conn_list); > return 0; > -- > 2.16.4 > _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel