From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 060C1CA9EA0 for ; Mon, 28 Oct 2019 06:31:06 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7933820862 for ; Mon, 28 Oct 2019 06:31:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="Zg2J7NeB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7933820862 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 41B0C1945; Mon, 28 Oct 2019 07:30:13 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 41B0C1945 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1572244263; bh=7LbncgtB+iAcCE7dP25OV3Xz4Tfc6GaPgmxJJjeujLg=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Zg2J7NeB67Pe0fRqrDLy8JGK7jldDlJWcj6AkHiIeLvCj2fTiayfudbJ6xfkLVzKM L+fUMjN/tFkjvZcVGFN3kKurX+ENmL0Gh+ml9vvO/NIvXILrNySh4n1q6CICke1W6R qKAPCqB5Y0WMlcjQC4MNXzYgsNZGQcJOesLHP9p4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C3E17F802BD; Mon, 28 Oct 2019 07:30:12 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 30FBCF80361; Mon, 28 Oct 2019 07:30:11 +0100 (CET) Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 7496DF800E7 for ; Mon, 28 Oct 2019 07:30:07 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 7496DF800E7 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 372A9B299; Mon, 28 Oct 2019 06:30:07 +0000 (UTC) Date: Mon, 28 Oct 2019 07:30:06 +0100 Message-ID: From: Takashi Iwai To: Navid Emamdoost In-Reply-To: <20191027192415.32743-1-navid.emamdoost@gmail.com> References: <20191027192415.32743-1-navid.emamdoost@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Cc: Hariprasad Kelam , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kjlu@umn.edu, Takashi Iwai , emamd001@umn.edu, smccaman@umn.edu, Tim Blechmann , Thomas Gleixner , Allison Randal Subject: Re: [alsa-devel] [PATCH] ALSA: lx6464es: Fix memory leaks in snd_lx6464es_create X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sun, 27 Oct 2019 20:24:13 +0100, Navid Emamdoost wrote: > > In the implementation of snd_lx6464es_create() it there are memory leaks > when error happens. Go to error path if any of these calls fail: > lx_init_dsp(), lx_pcm_create(), lx_proc_create(), snd_ctl_add(). Again no for this patch, it'll lead to double-frees. After registered via snd_device_new(), the device object gets released by its callback and the single snd_card_free() call suffices. thanks, Takashi > > Fixes: 02bec4904508 ("ALSA: lx6464es - driver for the digigram lx6464es interface") > Signed-off-by: Navid Emamdoost > --- > sound/pci/lx6464es/lx6464es.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/sound/pci/lx6464es/lx6464es.c b/sound/pci/lx6464es/lx6464es.c > index fe10714380f2..7c6e8f4ef826 100644 > --- a/sound/pci/lx6464es/lx6464es.c > +++ b/sound/pci/lx6464es/lx6464es.c > @@ -1020,25 +1020,26 @@ static int snd_lx6464es_create(struct snd_card *card, > err = lx_init_dsp(chip); > if (err < 0) { > dev_err(card->dev, "error during DSP initialization\n"); > - return err; > + goto cleanup; > } > > err = lx_pcm_create(chip); > if (err < 0) > - return err; > + goto cleanup; > > err = lx_proc_create(card, chip); > if (err < 0) > - return err; > + goto cleanup; > > err = snd_ctl_add(card, snd_ctl_new1(&lx_control_playback_switch, > chip)); > if (err < 0) > - return err; > + goto cleanup; > > *rchip = chip; > return 0; > > +cleanup: > device_new_failed: > free_irq(pci->irq, chip); > > -- > 2.17.1 > _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel