From: Takashi Iwai <tiwai@suse.de>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: clemens@ladisch.de, alsa-devel@alsa-project.org, stable@vger.kernel.org
Subject: Re: [PATCH] ALSA: firewire-lib/fireworks: fix miss detection of received MIDI messages
Date: Fri, 28 Jun 2019 10:52:57 +0200 [thread overview]
Message-ID: <s5ho92i6qhi.wl-tiwai@suse.de> (raw)
In-Reply-To: <20190628052158.27693-1-o-takashi@sakamocchi.jp>
On Fri, 28 Jun 2019 07:21:58 +0200,
Takashi Sakamoto wrote:
>
> In IEC 61883-6, 8 MIDI data streams are multiplexed into single
> MIDI conformant data channel. The index of stream is calculated by
> modulo 8 of the value of data block counter.
>
> In fireworks, the value of data block counter in CIP header has a quirk
> with firmware version v5.0.0, v5.7.3 and v5.8.0. This brings ALSA
> IEC 61883-1/6 packet streaming engine to miss detection of MIDI
> messages.
>
> This commit fixes the miss detection to modify the value of data block
> counter for the modulo calculation.
>
> For maintainers, this bug exists since a commit 18f5ed365d3f ("ALSA:
> fireworks/firewire-lib: add support for recent firmware quirk") in Linux
> kernel v4.2. There're many changes since the commit. This fix can be
> backported to Linux kernel v4.4 or later. I tagged a base commit to the
> backport for your convenience.
>
> Fixes: df075feefbd3 ("ALSA: firewire-lib: complete AM824 data block processing layer")
> Cc: <stable@vger.kernel.org> # v4.4+
> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
This doesn't seem applicable to the latest 5.2-rc tree due to your
recent refactoring. Could you resubmit the fix for 5.2? I'll resolve
the merge conflict in my side.
thanks,
Takashi
next prev parent reply other threads:[~2019-06-28 8:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 5:21 [PATCH] ALSA: firewire-lib/fireworks: fix miss detection of received MIDI messages Takashi Sakamoto
2019-06-28 8:52 ` Takashi Iwai [this message]
2019-06-28 7:34 ` Takashi Sakamoto
2019-06-28 15:44 ` Takashi Iwai
2019-06-28 14:56 ` Takashi Sakamoto
-- strict thread matches above, loose matches on Subject: below --
2019-07-01 10:59 Takashi Sakamoto
2019-07-01 14:14 ` Takashi Iwai
2019-07-01 14:23 ` Takashi Sakamoto
2019-07-01 14:26 ` Takashi Iwai
2019-07-01 14:31 ` Takashi Sakamoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5ho92i6qhi.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=o-takashi@sakamocchi.jp \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox