Re: [PATCH 7/7] ALSA: hda/tegra: add driver flag for runtime PM

[Takashi Iwai <tiwai@suse.de>]

On Mon, 21 Jan 2019 18:41:37 +0100,
Sameer Pujar wrote:
> 
> AZX_DCAPS_PM_RUNTIME flag is added to indicate support for runtime PM.
> azx_has_pm_runtime() can be called to check if above is enabled. The
> flag is put under CONFIG_PM check.
> 
> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
> Reviewed-by: Ravindra Lokhande <rlokhande@nvidia.com>
> Reviewed-by: Mohan Kumar D <mkumard@nvidia.com>

This can be more simply done in hda_controller.h.  Namely, a change
like:

--- a/sound/pci/hda/hda_controller.h
+++ b/sound/pci/hda/hda_controller.h
@@ -49,7 +49,11 @@
 #define AZX_DCAPS_4K_BDLE_BOUNDARY (1 << 23)	/* BDLE in 4k boundary */
 /* 24 unused */
 #define AZX_DCAPS_COUNT_LPIB_DELAY  (1 << 25)	/* Take LPIB as delay */
+#ifdef CONFIG_PM
 #define AZX_DCAPS_PM_RUNTIME	(1 << 26)	/* runtime PM support */
+#else
+#define AZX_DCAPS_PM_RUNTIME	0		/* N/A */
+#endif
 /* 27 unused */
 #define AZX_DCAPS_CORBRP_SELF_CLEAR (1 << 28)	/* CORBRP clears itself after reset */
 #define AZX_DCAPS_NO_MSI64      (1 << 29)	/* Stick to 32-bit MSIs */


thanks,

Takashi