From: Takashi Iwai <tiwai@suse.de>
To: han.lu@intel.com
Cc: liam.r.girdwood@linux.intel.com, alsa-devel@alsa-project.org
Subject: Re: [PATCH 0/6] *** alsabat: clean structure and tinyalsa support ***
Date: Tue, 22 Mar 2016 08:30:49 +0100 [thread overview]
Message-ID: <s5hoaa7rmty.wl-tiwai@suse.de> (raw)
In-Reply-To: <cover.1458623090.git.han.lu@intel.com>
On Tue, 22 Mar 2016 06:10:23 +0100,
han.lu@intel.com wrote:
>
> From: "Lu, Han" <han.lu@intel.com>
>
> 1. Clean structure, use general function to replace local processes.
Your patches have no description "why" at all, so I don't know why I
need to merge them, either. It's one of most important information.
Please explain why you need the change in each patch description to
convince readers.
> 2. Add tinyalsa support, configure will read environment and decide to
> link to ALSA lib or tinyalsa lib.
It's not good to choose tinyalsa forcibly whenever it's found. Then
there is no way to build alsabat with alsa-lib on a system that have
both libraries installed.
Better to add configure option to choose the backend, not only
detecting it.
thanks,
Takashi
>
> Lu, Han (6):
> alsabat: clean file process on capture thread loop
> alsabat: use common wav process function in playback loop
> alsabat: clean return value of playback and capture loops
> alsabat: use common data generator function
> alsabat: move alsa process to alsa.c
> alsabat: add tinyalsa support
>
> bat/Makefile.am | 12 +-
> bat/alsa.c | 217 +++++++++++---------------
> bat/alsabat.1 | 3 +
> bat/bat.c | 58 +++----
> bat/common.c | 68 +++++++++
> bat/common.h | 17 ++-
> bat/signal.c | 13 +-
> bat/tinyalsa.c | 460 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> bat/tinyalsa.h | 20 +++
> configure.ac | 4 +
> 10 files changed, 698 insertions(+), 174 deletions(-)
> create mode 100644 bat/tinyalsa.c
> create mode 100644 bat/tinyalsa.h
>
> --
> 2.5.0
>
next prev parent reply other threads:[~2016-03-22 7:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 5:10 [PATCH 0/6] *** alsabat: clean structure and tinyalsa support *** han.lu
2016-03-22 5:10 ` [PATCH 1/6] alsabat: clean file process on capture thread loop han.lu
2016-03-22 5:10 ` [PATCH 2/6] alsabat: use common wav process function in playback loop han.lu
2016-03-22 5:10 ` [PATCH 3/6] alsabat: clean return value of playback and capture loops han.lu
2016-03-22 5:10 ` [PATCH 4/6] alsabat: use common data generator function han.lu
2016-03-22 5:10 ` [PATCH 5/6] alsabat: move alsa process to alsa.c han.lu
2016-03-22 5:10 ` [PATCH 6/6] alsabat: add tinyalsa support han.lu
2016-03-22 7:30 ` Takashi Iwai [this message]
2016-03-22 14:31 ` [PATCH 0/6] *** alsabat: clean structure and tinyalsa support *** Lu, Han
2016-03-22 14:41 ` Takashi Iwai
2016-03-22 15:17 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hoaa7rmty.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=han.lu@intel.com \
--cc=liam.r.girdwood@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).