From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH] topology: Include <linux/types.h> in API
	header file
Date: Fri, 06 Nov 2015 13:59:41 +0100
Message-ID: <s5hoaf7z3k2.wl-tiwai@suse.de>
References: <1446813576-29295-1-git-send-email-mengdong.lin@linux.intel.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (mx2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id 525E5260429
 for <alsa-devel@alsa-project.org>; Fri,  6 Nov 2015 13:59:42 +0100 (CET)
In-Reply-To: <1446813576-29295-1-git-send-email-mengdong.lin@linux.intel.com>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: mengdong.lin@linux.intel.com
Cc: alsa-devel@alsa-project.org, vinod.koul@intel.com, mengdong.lin@intel.com, broonie@kernel.org, liam.r.girdwood@intel.com, subhransu.s.prusty@intel.com
List-Id: alsa-devel@alsa-project.org

On Fri, 06 Nov 2015 13:39:36 +0100,
mengdong.lin@linux.intel.com wrote:
> 
> From: Mengdong Lin <mengdong.lin@linux.intel.com>
> 
> Include <linux/types.h> in the API header file topology.h
> 
> The struct snd_tplg_stream_caps_template has a member "formats"
> of type __le64. So <linux/types.h> is needed.

We shouldn't use __le64 for user-space API.  I couldn't find it in
include/topology.h.  Where is it used?

Of course, it's fine to use it for kernel ABI.  But then linux/types.h
is already included in local.h, so it shouldn't be a problem.


Takashi

> 
> Signed-off-by: Mengdong Lin <mengdong.lin@linux.intel.com>
> 
> diff --git a/include/topology.h b/include/topology.h
> index b631871..5ee67e2 100644
> --- a/include/topology.h
> +++ b/include/topology.h
> @@ -21,6 +21,8 @@
>  #ifndef __ALSA_TOPOLOGY_H
>  #define __ALSA_TOPOLOGY_H
>  
> +#include <linux/types.h>
> +
>  #ifdef __cplusplus
>  extern "C" {
>  #endif
> -- 
> 1.9.1
>