From: Takashi Iwai <tiwai@suse.de>
To: Vinod Koul <vinod.koul@intel.com>
Cc: liam.r.girdwood@linux.intel.com, patches.audio@intel.com,
alsa-devel@alsa-project.org, broonie@kernel.org,
Jeeja KP <jeeja.kp@intel.com>
Subject: Re: [PATCH 1/3] ALSA: HDA: Fix stream assignment for host in decoupled mode
Date: Tue, 04 Aug 2015 07:12:16 +0200 [thread overview]
Message-ID: <s5hoaind4cv.wl-tiwai@suse.de> (raw)
In-Reply-To: <1438660720-30033-2-git-send-email-vinod.koul@intel.com>
On Tue, 04 Aug 2015 05:58:38 +0200,
Vinod Koul wrote:
>
> From: Jeeja KP <jeeja.kp@intel.com>
>
> This fixes issue in assigning host stream in case of
> decoupled mode. The check to verify if the stream is already
> in use was wrong so fix that
>
> Signed-off-by: Jeeja KP <jeeja.kp@intel.com>
> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Applied, thanks.
Takashi
> ---
> sound/hda/ext/hdac_ext_stream.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/hda/ext/hdac_ext_stream.c b/sound/hda/ext/hdac_ext_stream.c
> index f8ffbdbb450d..3de47dd1a76d 100644
> --- a/sound/hda/ext/hdac_ext_stream.c
> +++ b/sound/hda/ext/hdac_ext_stream.c
> @@ -299,7 +299,7 @@ hdac_ext_host_stream_assign(struct hdac_ext_bus *ebus,
> if (stream->direction != substream->stream)
> continue;
>
> - if (stream->opened) {
> + if (!stream->opened) {
> if (!hstream->decoupled)
> snd_hdac_ext_stream_decouple(ebus, hstream, true);
> res = hstream;
> --
> 1.9.1
>
next prev parent reply other threads:[~2015-08-04 5:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 3:58 [PATCH 0/3] ALSA: hdac: stream fixes Vinod Koul
2015-08-04 3:58 ` [PATCH 1/3] ALSA: HDA: Fix stream assignment for host in decoupled mode Vinod Koul
2015-08-04 5:12 ` Takashi Iwai [this message]
2015-08-04 3:58 ` [PATCH 2/3] ALSA: HDA: Dont check return for snd_hdac_chip_readl Vinod Koul
2015-08-04 5:12 ` Takashi Iwai
2015-08-04 3:58 ` [PATCH 3/3] ALSA: HDA: wait for RIRB, CORB DMA to finish Vinod Koul
2015-08-04 5:13 ` Takashi Iwai
2015-08-04 9:10 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hoaind4cv.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jeeja.kp@intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=patches.audio@intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox