From: Takashi Iwai <tiwai@suse.de>
To: Hui Wang <hui.wang@canonical.com>
Cc: alsa-devel@alsa-project.org, stable@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda - fix headset mic detection problem for one more machine
Date: Fri, 24 Apr 2015 07:58:38 +0200 [thread overview]
Message-ID: <s5hoamekqy9.wl-tiwai@suse.de> (raw)
In-Reply-To: <1429853999-19218-1-git-send-email-hui.wang@canonical.com>
At Fri, 24 Apr 2015 13:39:59 +0800,
Hui Wang wrote:
>
> We have two machines with alc256 codec in the pin quirk table, so
> moving the common pins to ALC256_STANDARD_PINS.
>
> Cc: stable@vger.kernel.org
> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1447909
> Signed-off-by: Hui Wang <hui.wang@canonical.com>
Applied, thanks.
Takashi
> ---
> sound/pci/hda/patch_realtek.c | 24 +++++++++++++++---------
> 1 file changed, 15 insertions(+), 9 deletions(-)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 03975d03..2a72da7 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -5228,6 +5228,16 @@ static const struct hda_model_fixup alc269_fixup_models[] = {
> {0x1b, 0x411111f0}, \
> {0x1e, 0x411111f0}
>
> +#define ALC256_STANDARD_PINS \
> + {0x12, 0x90a60140}, \
> + {0x14, 0x90170110}, \
> + {0x19, 0x411111f0}, \
> + {0x1a, 0x411111f0}, \
> + {0x1b, 0x411111f0}, \
> + {0x1d, 0x40700001}, \
> + {0x1e, 0x411111f0}, \
> + {0x21, 0x02211020}
> +
> #define ALC282_STANDARD_PINS \
> {0x14, 0x90170110}, \
> {0x18, 0x411111f0}, \
> @@ -5328,15 +5338,11 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
> {0x1d, 0x40700001},
> {0x21, 0x02211050}),
> SND_HDA_PIN_QUIRK(0x10ec0256, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE,
> - {0x12, 0x90a60140},
> - {0x13, 0x40000000},
> - {0x14, 0x90170110},
> - {0x19, 0x411111f0},
> - {0x1a, 0x411111f0},
> - {0x1b, 0x411111f0},
> - {0x1d, 0x40700001},
> - {0x1e, 0x411111f0},
> - {0x21, 0x02211020}),
> + ALC256_STANDARD_PINS,
> + {0x13, 0x40000000}),
> + SND_HDA_PIN_QUIRK(0x10ec0256, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE,
> + ALC256_STANDARD_PINS,
> + {0x13, 0x411111f0}),
> SND_HDA_PIN_QUIRK(0x10ec0280, 0x103c, "HP", ALC280_FIXUP_HP_GPIO4,
> {0x12, 0x90a60130},
> {0x13, 0x40000000},
> --
> 1.9.1
>
prev parent reply other threads:[~2015-04-24 5:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-24 5:39 [PATCH] ALSA: hda - fix headset mic detection problem for one more machine Hui Wang
2015-04-24 5:58 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hoamekqy9.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=hui.wang@canonical.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox