From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] ALSA: compress: Pass through return value of open ops callback Date: Wed, 19 Mar 2014 15:47:19 +0100 Message-ID: References: <1395233979-7675-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 433F52650D1 for ; Wed, 19 Mar 2014 15:47:20 +0100 (CET) In-Reply-To: <1395233979-7675-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Charles Keepax Cc: vinod.koul@intel.com, alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com List-Id: alsa-devel@alsa-project.org At Wed, 19 Mar 2014 12:59:39 +0000, Charles Keepax wrote: > > The snd_compr_open function would always return 0 even if the compressed > ops open function failed, obviously this is incorrect. Looks like this > was introduced by a small typo in: > > commit a0830dbd4e42b38aefdf3fb61ba5019a1a99ea85 > ALSA: Add a reference counter to card instance > > This patch returns the value from the compressed op as it should. > > Signed-off-by: Charles Keepax Applied with ack by Vinod. I added Cc to stable. thanks, Takashi > --- > sound/core/compress_offload.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c > index 7a20897..7403f34 100644 > --- a/sound/core/compress_offload.c > +++ b/sound/core/compress_offload.c > @@ -133,7 +133,7 @@ static int snd_compr_open(struct inode *inode, struct file *f) > kfree(data); > } > snd_card_unref(compr->card); > - return 0; > + return ret; > } > > static int snd_compr_free(struct inode *inode, struct file *f) > -- > 1.7.2.5 >