alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Бойко Максим" <maksboyko@yandex.ru>
Cc: alsa-devel@alsa-project.org, linux-usb@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH] Fix invalid volume resolution for Logitech HD	Webcam C525
Date: Thu, 08 Aug 2013 10:42:56 +0200	[thread overview]
Message-ID: <s5hob98a7zj.wl%tiwai@suse.de> (raw)
In-Reply-To: <80181375903486@web11g.yandex.ru>

At Wed, 07 Aug 2013 23:24:46 +0400,
Бойко Максим wrote:
> 
> From: Maksim Boyko <maksim.a.boyko@gmail.com>
> 
> Add the volume control quirk for avoiding the kernel warning for Logitech HD Webcam C525.
> The similar patch was previously reported for Logitech HD Webcam C310 (see 36691e1be6ec551eef4a5225f126a281f8c051c2).

Your sign-off is missing.  And the patch can't be applied cleanly as
is, likely because your MUA broke the spaces/tabs.

Could you resubmit with the fixes?


thanks,

Takashi


> 
> --- linux-3.10.5-orig/sound/usb/mixer.c	2013-08-04 12:51:49.000000000 +0400
> +++ linux-3.10.5/sound/usb/mixer.c	2013-08-06 21:12:42.274197287 +0400
> @@ -888,6 +888,7 @@
>          case USB_ID(0x046d, 0x081b): /* HD Webcam c310 */
>          case USB_ID(0x046d, 0x081d): /* HD Webcam c510 */
>          case USB_ID(0x046d, 0x0825): /* HD Webcam c270 */
> +	case USB_ID(0x046d, 0x0826): /* HD Webcam c525 */
>          case USB_ID(0x046d, 0x0991):
>          /* Most audio usb devices lie about volume resolution.
>           * Most Logitech webcams have res = 384.
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 

      parent reply	other threads:[~2013-08-08  8:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-07 19:24 [PATCH] Fix invalid volume resolution for Logitech HD Webcam C525 Бойко Максим
2013-08-07 19:34 ` Greg KH
     [not found] ` <80181375903486-HW/GO1vs6rtxpj1cXAZ9Bg@public.gmane.org>
2013-08-07 19:40   ` Sergei Shtylyov
2013-08-08  8:42 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hob98a7zj.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=maksboyko@yandex.ru \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).