From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: CONFIG_SND_DEBUG (was: Re: [PATCH] ALSA: get rid of CONFIG_SND_VERBOSE_PRINTK) Date: Wed, 05 Jun 2013 10:46:39 +0200 Message-ID: References: <1370375134.2385.64.camel@joe-AO722> <1370412921.2385.111.camel@joe-AO722> <1370415121.2385.124.camel@joe-AO722> <1370416077.2385.137.camel@joe-AO722> <1370417670.2385.148.camel@joe-AO722> <51AEED12.20502@canonical.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 99E062652F9 for ; Wed, 5 Jun 2013 10:46:04 +0200 (CEST) In-Reply-To: <51AEED12.20502@canonical.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: David Henningsson Cc: alsa-devel@alsa-project.org, Andy Whitcroft , Kernel team list , Alan Stern , Joe Perches , leann.ogasawara@canonical.com List-Id: alsa-devel@alsa-project.org At Wed, 05 Jun 2013 09:47:30 +0200, David Henningsson wrote: > > On 06/05/2013 09:34 AM, Joe Perches wrote: > > On Wed, 2013-06-05 at 09:22 +0200, Takashi Iwai wrote: > >> At Wed, 05 Jun 2013 00:07:57 -0700, Joe Perches wrote: > >>> On Wed, 2013-06-05 at 08:54 +0200, Takashi Iwai wrote: > >>>> At Tue, 04 Jun 2013 23:52:01 -0700, Joe Perches wrote: > >>>>> On Wed, 2013-06-05 at 08:32 +0200, Takashi Iwai wrote: > >>>>>> Yes. These are snd_printd() just to be conditionally built in. > >>>>>> But in most cases it's rather useful to print them (as most distros > >>>>>> set CONFIG_SND_DEBUG=y). > >>>>> Ubuntu doesn't, I believe Fedora doesn't. > >>>> Then they should have done so :) > >>> But they don't, so what distros do? > >> > >> RedHat (including Fedora) and SUSE do at least. > > > > Mandriva does too. (still looking around for others) > > > > We can ask Ubuntu to enable CONFIG_SND_DEBUG. > > (cc'd Andy Whitcroft, Leann Ogasawara and David Henningsson) > > > > Maybe there are others Canonical folk that > > should be cc'd? > > Adding kernel team mailing list to CC. > > Andy/Leann - apparently CONFIG_SND_DEBUG is on by default from upstream, > and we explicitly disable it. Is there any reason why we do that? Inheriting from Debian? Note that CONFIG_SND_DEBUG=n is correct if you are really sure that the driver works fine on your device and you want to keep the kernel as minimal as possible. For generic kernels, better to set this option because it also enables more safety checks. Takashi