Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: alsa-devel@alsa-project.org, nicolas.ferre@atmel.com,
	egtvedt@samfundet.no
Subject: Re: [PATCH 1/1] ALSA: atmel: Remove redundant platform_set_drvdata()
Date: Fri, 03 May 2013 11:49:24 +0200	[thread overview]
Message-ID: <s5hobcsxujf.wl%tiwai@suse.de> (raw)
In-Reply-To: <1367564188-14674-1-git-send-email-sachin.kamat@linaro.org>

At Fri,  3 May 2013 12:26:28 +0530,
Sachin Kamat wrote:
> 
> Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
> driver is bound) removes the need to set driver data field to
> NULL.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>

Thanks, applied now with acks by Hans-Christian and Nicolas.


Takashi

> ---
>  sound/atmel/abdac.c |    2 --
>  sound/atmel/ac97c.c |    2 --
>  2 files changed, 4 deletions(-)
> 
> diff --git a/sound/atmel/abdac.c b/sound/atmel/abdac.c
> index 071ce1b..872d59e 100644
> --- a/sound/atmel/abdac.c
> +++ b/sound/atmel/abdac.c
> @@ -583,8 +583,6 @@ static int atmel_abdac_remove(struct platform_device *pdev)
>  	free_irq(dac->irq, dac);
>  	snd_card_free(card);
>  
> -	platform_set_drvdata(pdev, NULL);
> -
>  	return 0;
>  }
>  
> diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c
> index 6b7e2b5..ae63d22 100644
> --- a/sound/atmel/ac97c.c
> +++ b/sound/atmel/ac97c.c
> @@ -1199,8 +1199,6 @@ static int atmel_ac97c_remove(struct platform_device *pdev)
>  	snd_card_set_dev(card, NULL);
>  	snd_card_free(card);
>  
> -	platform_set_drvdata(pdev, NULL);
> -
>  	return 0;
>  }
>  
> -- 
> 1.7.9.5
> 

      parent reply	other threads:[~2013-05-03  9:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-03  6:56 [PATCH 1/1] ALSA: atmel: Remove redundant platform_set_drvdata() Sachin Kamat
2013-05-03  7:13 ` Hans-Christian Egtvedt
2013-05-03  7:16 ` Nicolas Ferre
2013-05-03  9:49 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hobcsxujf.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=egtvedt@samfundet.no \
    --cc=nicolas.ferre@atmel.com \
    --cc=sachin.kamat@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox