From: Takashi Iwai <tiwai@suse.de>
To: Ian Minett <ian_minett@creativelabs.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 8/8] ALSA: Change return value for load_dsp_prepare() to -ENOSYS
Date: Fri, 14 Sep 2012 11:01:29 +0200 [thread overview]
Message-ID: <s5hobl9c712.wl%tiwai@suse.de> (raw)
In-Reply-To: <1347585358-2403-9-git-send-email-ian_minett@creativelabs.com>
At Thu, 13 Sep 2012 18:15:58 -0700,
Ian Minett wrote:
>
> From: Ian Minett <ian_minett@creativelabs.com>
>
> Signed-off-by: Ian Minett <ian_minett@creativelabs.com>
This depends on what is the expected. If the function call is
mandatory for both cases with and without DSP loader implementation,
just returning zero is more practical.
In this case... well, maybe ca0132 is the only user, so I think it's
OK to return an error like this.
Takashi
> diff --git a/sound/pci/hda/hda_codec.h b/sound/pci/hda/hda_codec.h
> index 159e07a..ac60300 100644
> --- a/sound/pci/hda/hda_codec.h
> +++ b/sound/pci/hda/hda_codec.h
> @@ -1164,7 +1164,7 @@ snd_hda_codec_load_dsp_prepare(struct hda_codec *codec, unsigned int format,
> unsigned int size,
> struct snd_dma_buffer *bufp)
> {
> - return 0;
> + return -ENOSYS;
> }
> static inline void
> snd_hda_codec_load_dsp_trigger(struct hda_codec *codec, bool start) {}
> --
> 1.7.4.1
>
next prev parent reply other threads:[~2012-09-14 9:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-14 1:15 [PATCH 0/8] ALSA: Add DSP firmware loader (resub) Ian Minett
2012-09-14 1:15 ` [PATCH 1/8] ALSA: Make snd_sgbuf_get_{ptr|addr}() available for non-SG cases Ian Minett
2012-09-14 1:15 ` [PATCH 2/8] ALSA: Add new DSP loader callback routines Ian Minett
2012-09-14 1:15 ` [PATCH 3/8] ALSA: Add CA0132 register definitions file Ian Minett
2012-09-14 1:15 ` [PATCH 4/8] ALSA: Add DSP firmware enums and defs to CA0132 codec Ian Minett
2012-09-14 8:40 ` Takashi Iwai
2012-09-14 1:15 ` [PATCH 5/8] ALSA: Update CA0132 codec to load DSP firmware binary Ian Minett
2012-09-14 8:51 ` Takashi Iwai
2012-09-14 8:52 ` Takashi Iwai
2012-09-14 1:15 ` [PATCH 6/8] ALSA: Add firmware caching to CA0132 codec Ian Minett
2012-09-14 8:57 ` Takashi Iwai
2012-09-14 1:15 ` [PATCH 7/8] ALSA: Add comments and descriptions to functions Ian Minett
2012-09-14 8:59 ` Takashi Iwai
2012-09-14 1:15 ` [PATCH 8/8] ALSA: Change return value for load_dsp_prepare() to -ENOSYS Ian Minett
2012-09-14 9:01 ` Takashi Iwai [this message]
2012-09-14 8:32 ` [PATCH 0/8] ALSA: Add DSP firmware loader (resub) Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hobl9c712.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=ian_minett@creativelabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).