From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [snd-asihpi 1/8] Clock source is neither capture nor playback. Add spaces to control name string for consistency. Date: Fri, 01 Apr 2011 15:09:12 +0200 Message-ID: References: <1301626792-13705-1-git-send-email-linux@audioscience.com> <1301626792-13705-2-git-send-email-linux@audioscience.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 745AB10381A for ; Fri, 1 Apr 2011 15:09:13 +0200 (CEST) In-Reply-To: <1301626792-13705-2-git-send-email-linux@audioscience.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: linux@audioscience.com Cc: Eliot Blennerhassett , alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Fri, 01 Apr 2011 15:59:45 +1300, linux@audioscience.com wrote: > > From: Eliot Blennerhassett > > Signed-off-by: Eliot Blennerhassett In general to all your patches, please reduce the summary line, i.e. a concise headline and more details in the changelog. thanks, Takashi > --- > pci/asihpi/asihpi.c | 8 +++++--- > 1 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/pci/asihpi/asihpi.c b/pci/asihpi/asihpi.c > index f53a31e..edcbe39 100644 > --- a/pci/asihpi/asihpi.c > +++ b/pci/asihpi/asihpi.c > @@ -1413,14 +1413,16 @@ static void asihpi_ctl_init(struct snd_kcontrol_new *snd_control, > struct hpi_control *hpi_ctl, > char *name) > { > - char *dir = ""; > + char *dir; > memset(snd_control, 0, sizeof(*snd_control)); > snd_control->name = hpi_ctl->name; > snd_control->private_value = hpi_ctl->h_control; > snd_control->iface = SNDRV_CTL_ELEM_IFACE_MIXER; > snd_control->index = 0; > > - if (hpi_ctl->dst_node_type + HPI_DESTNODE_NONE == HPI_DESTNODE_ISTREAM) > + if (hpi_ctl->src_node_type + HPI_SOURCENODE_NONE == HPI_SOURCENODE_CLOCK_SOURCE) > + dir = ""; /* clock is neither capture nor playback */ > + else if (hpi_ctl->dst_node_type + HPI_DESTNODE_NONE == HPI_DESTNODE_ISTREAM) > dir = "Capture "; /* On or towards a PCM capture destination*/ > else if ((hpi_ctl->src_node_type + HPI_SOURCENODE_NONE != HPI_SOURCENODE_OSTREAM) && > (!hpi_ctl->dst_node_type)) > @@ -1433,7 +1435,7 @@ static void asihpi_ctl_init(struct snd_kcontrol_new *snd_control, > dir = "Playback "; /* PCM Playback source, or output node */ > > if (hpi_ctl->src_node_type && hpi_ctl->dst_node_type) > - sprintf(hpi_ctl->name, "%s%d %s%d %s%s", > + sprintf(hpi_ctl->name, "%s %d %s %d %s%s", > asihpi_src_names[hpi_ctl->src_node_type], > hpi_ctl->src_node_index, > asihpi_dst_names[hpi_ctl->dst_node_type], > -- > 1.7.0.4 >