From: Takashi Iwai <tiwai@suse.de>
To: "Michaël Cadilhac" <michael@cadilhac.name>
Cc: alsa-devel@alsa-project.org
Subject: Re: Getting pcm_usb_stream plugin to know its limits. [Kind of SOLVED]
Date: Tue, 12 Jan 2010 10:52:09 +0100 [thread overview]
Message-ID: <s5hockz646u.wl%tiwai@suse.de> (raw)
In-Reply-To: <yvzgiqb8fq1k.fsf@cadilhac.name>
At Mon, 11 Jan 2010 13:35:19 -0500,
Michaël Cadilhac wrote:
>
> michael@cadilhac.name (Michaël Cadilhac) writes:
>
> > michael@cadilhac.name (Michaël Cadilhac) writes:
> >
> >> So, my final saying is the following patch. It fixes the segfault on
> >> stopping a non-started usb_stream, plus it adds the ability to set a
> >> period size and sound rate. The latter offers a workaround for the
> >> second issue I came with (that the default values for period bytes, and
> >> hence period size, were too high for us122l to work).
> >
> > Any comment on that patch would be greatly appreciated. I'm just
> > wondering if it's safe for me to give it to some people.
>
> Anyone? Note that this also fixes a real bug, so it might be of
> interest to include it in the trunk.
Through a quick glance, the patch looks OK to me.
Could you give a proper subject and changelog to merge your patch
to git tree?
thanks,
Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2010-01-12 9:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-30 17:48 Getting pcm_usb_stream plugin to know its limits Michaël Cadilhac
2009-12-30 17:58 ` Michaël Cadilhac
2009-12-31 4:15 ` Michaël Cadilhac
2009-12-31 4:57 ` Getting pcm_usb_stream plugin to know its limits. [Kind of SOLVED] Michaël Cadilhac
2010-01-05 3:26 ` Michaël Cadilhac
2010-01-11 18:35 ` Michaël Cadilhac
2010-01-12 9:52 ` Takashi Iwai [this message]
2010-02-02 5:24 ` Michaël Cadilhac
2010-02-10 22:56 ` Michaël Cadilhac
2010-02-22 9:04 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hockz646u.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=michael@cadilhac.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox