Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@sirena.org.uk>
Cc: alsa-devel@alsa-project.org
Subject: Re: Merged upstream to topic/asoc branch
Date: Mon, 01 Dec 2008 20:10:32 +0100	[thread overview]
Message-ID: <s5hoczviudz.wl%tiwai@suse.de> (raw)
In-Reply-To: <20081201174252.GK13758@sirena.org.uk>

At Mon, 1 Dec 2008 17:42:52 +0000,
Mark Brown wrote:
> 
> On Mon, Dec 01, 2008 at 06:37:17PM +0100, Takashi Iwai wrote:
> 
> > Oh, BTW, the following fix is also still pending on my local queue.
> 
> That fix looks good, I don't regularly track the Zaurii since keeping
> track of the build failures in mainline was more trouble than it was
> worth last time I tried.
> 
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

OK.  I also applied one more fix below.


Takashi

===
>From 682d5874f3d654b5d13d9b8dd56b9e05cfadd01b Mon Sep 17 00:00:00 2001
From: Takashi Iwai <tiwai@suse.de>
Date: Mon, 1 Dec 2008 20:03:54 +0100
Subject: [PATCH] ALSA: ASoC: Fix old-style trigger callback in s3c2443-ac97.c

Fix the old-style trigger callback in s3c2443-ac97.c:
    sound/soc/s3c24xx/s3c2443-ac97.c:378: warning: initialization from incompatible pointer type

Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/soc/s3c24xx/s3c2443-ac97.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/sound/soc/s3c24xx/s3c2443-ac97.c b/sound/soc/s3c24xx/s3c2443-ac97.c
index 41bde6a..f0bc9b7 100644
--- a/sound/soc/s3c24xx/s3c2443-ac97.c
+++ b/sound/soc/s3c24xx/s3c2443-ac97.c
@@ -285,7 +285,8 @@ static int s3c2443_ac97_hw_params(struct snd_pcm_substream *substream,
 	return 0;
 }
 
-static int s3c2443_ac97_trigger(struct snd_pcm_substream *substream, int cmd)
+static int s3c2443_ac97_trigger(struct snd_pcm_substream *substream, int cmd,
+				struct snd_soc_dai *dai)
 {
 	u32 ac_glbctrl;
 
-- 
1.6.0.4

  reply	other threads:[~2008-12-01 19:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-01 17:00 Merged upstream to topic/asoc branch Takashi Iwai
2008-12-01 17:04 ` Takashi Iwai
2008-12-01 17:06 ` Mark Brown
2008-12-01 17:14   ` Takashi Iwai
2008-12-01 17:24     ` Mark Brown
2008-12-01 17:32       ` Takashi Iwai
2008-12-01 17:37         ` Takashi Iwai
2008-12-01 17:42           ` Mark Brown
2008-12-01 19:10             ` Takashi Iwai [this message]
2008-12-01 19:11         ` Takashi Iwai
     [not found]           ` <s5hy6yojxrz.wl%tiwai@suse.de>
2008-12-10 11:25             ` Warnings in wm8903.c (Re: Merged upstream to topic/asoc branch) Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hoczviudz.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@sirena.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox