From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH] hda-codec - Fix definition of
	AC_KNBCAP_DELTA to match datasheet.
Date: Thu, 13 Dec 2007 12:08:09 +0100
Message-ID: <s5hodcukg2u.wl%tiwai@suse.de>
References: <76366b180712032312p73a98249hf9269e5044a818c2@mail.gmail.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (mx2.suse.de [195.135.220.15])
	by alsa0.perex.cz (Postfix) with ESMTP id D604724667
	for <alsa-devel@alsa-project.org>; Thu, 13 Dec 2007 13:17:10 +0100 (CET)
In-Reply-To: <76366b180712032312p73a98249hf9269e5044a818c2@mail.gmail.com>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Sender: alsa-devel-bounces@alsa-project.org
Errors-To: alsa-devel-bounces@alsa-project.org
To: Andrew Paprocki <andrew@ishiboo.com>
Cc: alsa-devel@alsa-project.org
List-Id: alsa-devel@alsa-project.org

At Tue, 4 Dec 2007 02:12:48 -0500,
Andrew Paprocki wrote:
> 
> hda-codec - Fix definition of AC_KNBCAP_DELTA to match datasheet.
> 
> AC_KNBCAP_DELTA is incorrectly defined as (1<<8). According to the ALC883
> datasheet rev 1.3, this is bit 7 after AC_KNBCAP_NUM_STEPS which is a 0x7f
> mask.
> 
> Signed-off-by: Andrew Paprocki <andrew@ishiboo.com>

This is a broken patch, too.  Please fix.


Thanks,

Takashi

> 
> 
> diff -r da002fb740a42b4fd6dcbd45693f9bee3c828812 -r
> 65b577e690e95e4ace950c3f986270dd3e992192 pci/hda/hda_codec.h
> --- a/pci/hda/hda_codec.h       Mon Dec 03 22:52:58 2007 -0500
> +++ b/pci/hda/hda_codec.h       Mon Dec 03 23:02:51 2007 -0500
> @@ -238,7 +238,7 @@ enum {
> 
>  /* Volume knobs capabilities */
>  #define AC_KNBCAP_NUM_STEPS            (0x7f<<0)
> -#define AC_KNBCAP_DELTA                        (1<<8)
> +#define AC_KNBCAP_DELTA                        (1<<7)
> 
>  /*
>   * Control Parameters
>