Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: danny@mailmij.org
Cc: Clemens Ladisch <clemens@ladisch.de>, alsa-devel@lists.sourceforge.net
Subject: Re: period/buffer bug on pmac ?
Date: Wed, 17 Nov 2004 12:45:01 +0100	[thread overview]
Message-ID: <s5hoehwsnr6.wl@alsa2.suse.de> (raw)
In-Reply-To: <Pine.LNX.4.33.0411161931330.15251-100000@luna.ellen.dexterslabs.com>

At Tue, 16 Nov 2004 19:37:39 +0100 (CET),
<danny@mailmij.org> wrote:
> 
> On Mon, 15 Nov 2004, Clemens Ladisch wrote:
> 
> > danny@mailmij.org wrote:
> > > In the process of fixing up the alsa output plugin of bmp a bit I've come
> > > upon a weird problem. The mp3s I was playing played to fast, with a
> > > audible click each few millisecond. This seemed to only happen when the
> > > period size was not a power of 2 (the output plugin used to set
> > > period_time). I've now calculated the period_size myself from the rate and
> > > set it to the nearest power of 2. Which seems to work fine,
> > 
> > There is no general power-of-2 requirement in ALSA.  The pmac driver
> > doesn't set a hardware constraint; if the hardware requires power-of-2
> > periods, it's a bug in the driver.
> > 
> Thanks for the reply!
> I've been hacking around a bit in the driver and think it needs some 
> contraints, although its not (like i first thought) limited to a power of 
> 2. Constraining periods to integer and requiring at least 3 periods seem 
> to fix all issues i have.

That's good to know!

>  However, these requirements sometimes 
> drastically affect the period AND buffersize requested by the app. I play 
> with it a bit more and submit a patch soon. 

Don't forget summary and signed-off-by lines :)


thanks,

Takashi


-------------------------------------------------------
This SF.Net email is sponsored by: InterSystems CACHE
FREE OODBMS DOWNLOAD - A multidimensional database that combines
robust object and relational technologies, making it a perfect match
for Java, C++,COM, XML, ODBC and JDBC. www.intersystems.com/match8

      reply	other threads:[~2004-11-17 11:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-11 21:17 period/buffer bug on pmac ? danny
2004-11-13 11:35 ` danny
2004-11-15 16:53 ` Clemens Ladisch
2004-11-16  9:57   ` Giuliano Pochini
2004-11-16 18:37   ` danny
2004-11-17 11:45     ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hoehwsnr6.wl@alsa2.suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@lists.sourceforge.net \
    --cc=clemens@ladisch.de \
    --cc=danny@mailmij.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox