Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Alexander Maassen <outsider@key2peace.org>
Cc: alsa-devel@lists.sourceforge.net
Subject: Re: alsa-drivers1.0.0rc2 won't compile on stock 2.6.1rc2 kernel - fixed it
Date: Thu, 08 Jan 2004 12:11:52 +0100	[thread overview]
Message-ID: <s5hoetezocn.wl@alsa2.suse.de> (raw)
In-Reply-To: <3FFC5F92.9000808@key2peace.org>

At Wed, 07 Jan 2004 20:35:46 +0100,
Alexander Maassen wrote:
> 
> [1  <text/plain; us-ascii (7bit)>]
> I had several issues getting alsa to compile and to load correctly, 
> after some debugging and lots of coffee I've been able to fix those.
> Included is a unified diff so you all can enjoy the work in case you 
> have the same error.

the patch seems invalid for me.
all of them are in the ifdef's which 2.6.x shouldn't pass.
i guess alsa-driver's configure script didn't check it correctly, or
you copied the wrong files into your kernel tree.

just run configure on the top of alsa-driver (with options if
necessary), or copy the files of alsa-kernel tree (not alsa-driver) to
linux source tree and make modules there.


ciao,

Takashi

> 
> Kind regards,
> Alexander Maassen
> [2 alsa-driver-1.0.0rc2.diff <text/plain (7bit)>]
> diff -burd alsa-driver-1.0.0rc2/acore/memory_wrapper.c alsa-driver-1.0.0rc2.new/acore/memory_wrapper.c
> --- alsa-driver-1.0.0rc2/acore/memory_wrapper.c	2003-11-10 18:32:37.000000000 +0100
> +++ alsa-driver-1.0.0rc2.new/acore/memory_wrapper.c	2004-01-07 20:00:10.000000000 +0100
> @@ -21,6 +21,10 @@
>  #endif
>  #endif
>  
> +#ifndef VMALLOC_VMADDR
> +#define VMALLOC_VMADDR(x) ((unsigned long)(x))
> +#endif
> +
>  /* vmalloc_to_page wrapper */
>  #ifndef CONFIG_HAVE_VMALLOC_TO_PAGE
>  #include <linux/highmem.h>
> @@ -38,7 +42,11 @@
>  #endif
>  	pgd = pgd_offset(&init_mm, lpage);
>  	pmd = pmd_offset(pgd, lpage);
> +#if LINUX_VERSION_CODE > KERNEL_VERSION(2,6,0)
> +	pte = pte_offset_kernel(pmd, lpage);
> +#else
>  	pte = pte_offset(pmd, lpage);
> +#endif
>  #if LINUX_VERSION_CODE < KERNEL_VERSION(2,4,0)
>  	page = virt_to_page(pte_page(*pte));
>  #else
>  
> diff -burd alsa-driver-1.0.0rc2/acore/sgbuf.c alsa-driver-1.0.0rc2.new/acore/sgbuf.c
> --- alsa-driver-1.0.0rc2/acore/sgbuf.c	2003-11-10 18:32:37.000000000 +0100
> +++ alsa-driver-1.0.0rc2.new/acore/sgbuf.c	2004-01-07 20:01:00.000000000 +0100
> @@ -44,7 +44,11 @@
>  	lpage = VMALLOC_VMADDR(pageptr);
>  	pgd = pgd_offset_k(lpage);
>  	pmd = pmd_offset(pgd, lpage);
> +#if LINUX_VERSION_CODE > KERNEL_VERSION(2,6,0)
> +	pte = pte_offset_kernel(pmd, lpage);
> +#else
>  	pte = pte_offset(pmd, lpage);
> +#endif
>  	return (void *)pte_page(*pte);
>  }    
>  #endif
>  
> diff -burd alsa-driver-1.0.0rc2/include/adriver.h alsa-driver-1.0.0rc2.new/include/adriver.h
> --- alsa-driver-1.0.0rc2/include/adriver.h	2003-11-20 14:23:27.000000000 +0100
> +++ alsa-driver-1.0.0rc2.new/include/adriver.h	2004-01-07 19:04:43.000000000 +0100
> @@ -128,6 +128,7 @@
>  #define need_resched() (current->need_resched)
>  #endif
>  #ifndef CONFIG_HAVE_PDE
> +#if LINUX_VERSION_CODE < KERNEL_VERSION(2, 6, 1)
>  #include <linux/fs.h>
>  #include <linux/proc_fs.h>
>  static inline struct proc_dir_entry *PDE(const struct inode *inode)
> @@ -135,6 +136,7 @@
>  	return (struct proc_dir_entry *) inode->u.generic_ip;
>  }
>  #endif
> +#endif
>  #ifndef cond_resched
>  #define cond_resched() \
>  	do { \


-------------------------------------------------------
This SF.net email is sponsored by: Perforce Software.
Perforce is the Fast Software Configuration Management System offering
advanced branching capabilities and atomic changes on 50+ platforms.
Free Eval! http://www.perforce.com/perforce/loadprog.html

      reply	other threads:[~2004-01-08 11:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-07 19:35 alsa-drivers1.0.0rc2 won't compile on stock 2.6.1rc2 kernel - fixed it Alexander Maassen
2004-01-08 11:11 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hoetezocn.wl@alsa2.suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@lists.sourceforge.net \
    --cc=outsider@key2peace.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox