From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76682C07E96 for ; Thu, 15 Jul 2021 08:32:15 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E25FD6120A for ; Thu, 15 Jul 2021 08:32:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E25FD6120A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7FD6A16FE; Thu, 15 Jul 2021 10:31:23 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7FD6A16FE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1626337933; bh=1riIwNAaBCNqPxOH9M4bFbUkCYycIDJgYyqA8/HWFI0=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=WWQKMqTygxLWPdfMAOgLZBXuGoVQbb7yQR5nRZ5LMmFEo3Y/XmBkilDq14HQgr9e3 0AqeFmVz98e60O0OZtoQHcN2j2KY+9ZoawjcMbFO1CsqxBFaVI+pS9yE3d1immUNxY R0dI0+CfwT25l/jdcqIxJBz4t+i3Xrjovl4RxmjQ= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 9F688F804E0; Thu, 15 Jul 2021 10:03:43 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7B363F804E0; Thu, 15 Jul 2021 10:03:42 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 3D77DF80240 for ; Thu, 15 Jul 2021 10:03:40 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 3D77DF80240 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="vU8ZYhz3"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="IOt0LmJS" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 1B529221D5; Thu, 15 Jul 2021 08:03:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1626336220; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KvTSH+YHvls/UF+nzKgZ6kRiLaDX5ZZ/rOOYgCEmUAo=; b=vU8ZYhz3sxfnRuV+LhV2jQC4NJmNBdjfwF3c0Yn7JeMMxmd312SZyuLGSOszf5MaNFBRAq 7OD5hXPEq2hW3i53QqmLRMX8wLnIJP0otLh55fOyP10rK+G3tMPWq8QOIdTzCjN8mIdlqP aLRatOxjG2wrd77eDYpn4MlTK4CX7fA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1626336220; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KvTSH+YHvls/UF+nzKgZ6kRiLaDX5ZZ/rOOYgCEmUAo=; b=IOt0LmJSdvCoelD2KUpW3pB5HS98WVLqNcrlgDgpCbrgPc6ksyvt5Jx2RUqOeC018Cc58H QbvPeIJ9KpoNLgCA== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 0E8C8A3B8D; Thu, 15 Jul 2021 08:03:40 +0000 (UTC) Date: Thu, 15 Jul 2021 10:03:40 +0200 Message-ID: From: Takashi Iwai To: "Ujfalusi, Peter" Subject: Re: [PATCH 0/2] ALSA: compress: Cleanup and a potential fix In-Reply-To: <2ac2e847-9c14-658e-8d75-0b93a8ddd0d6@linux.intel.com> References: <20210714162424.4412-1-tiwai@suse.de> <74151b06-a1cd-3a6b-ef1e-8db03eb815ad@gmail.com> <2ac2e847-9c14-658e-8d75-0b93a8ddd0d6@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Vinod Koul , Mark Brown , P9ter Ujfalusi , alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 15 Jul 2021 09:56:59 +0200, Ujfalusi, Peter wrote: > > > > On 7/15/2021 10:51, Péter Ujfalusi wrote: > > > > > > On 15/07/2021 06:39, Vinod Koul wrote: > >> On 14-07-21, 18:24, Takashi Iwai wrote: > >>> Hi, > >>> > >>> this series contains a couple of patches for compress-offload API, one > >>> for a cleanup of unused API functions and another for the proper mutex > >>> initialization. I stumbled on the second while doing the first. > >> > >> Thanks for the cleanup. We never have a compress only device and it is a > >> mix of PCM and compress FEs mostly :) > > > > Actually I'm working on a series where a card would only contain nothing > > else but a compr, no PCMs... > > and I should have replied from here ;) > > I'm preparing to split up the SOF into IPC clients [1] and the probes > support (which is using compress API) is going to be moved as a separate > client, creating it's own sound card with the single comprCxD0 (and the > controlCx). > > Is this cleanup going to prevent this? Unless you use snd_compress_register() function, nothing can break. And if you were to use the function together with ASoC, it must be very wrong :) Takashi