From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 377DDC48BD1 for ; Thu, 10 Jun 2021 08:38:08 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B5F23611CC for ; Thu, 10 Jun 2021 08:38:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B5F23611CC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3B42E1769; Thu, 10 Jun 2021 10:37:16 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3B42E1769 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1623314286; bh=SOKqeNhb72NcARRBAIGGr5qt2qPw6NHrJHPkemL+FWw=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=C/rnfIgdvRGHWnCmH5vU0erfmVWiXlnFG1oRzKrM2tzS5qaCcY8D/HZnPwAAsL3ik kxZGzYfF6VGr5BGG4nzqtf/Vf7+/7rtm+NN0vbctpnu4vUeIYdYoy4lHA23SS40OCF jkHc49tebAfX0K2Mkvv667MVaGwmd/yB9KDau6PA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 80993F804AD; Thu, 10 Jun 2021 10:37:13 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2D1C7F804B3; Thu, 10 Jun 2021 10:37:12 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 9498FF80218 for ; Thu, 10 Jun 2021 10:37:00 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 9498FF80218 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="tHxpaZQ+"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="/y43H0h3" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 1BA971FD60; Thu, 10 Jun 2021 08:36:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1623314218; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ldjzmlz6cIGfkfNrX2YwmWfxUK2Kb+bppA3zxB3fsc8=; b=tHxpaZQ+q06cp5dfUNISiJmcFnXWJfuW2FIwkAD5h5cNKPOa7AZyD2VIp5XRKGuHYLdIo5 FzJDoHPXIGeCx0L/0heSbvTEbEmhThCMsVsBvx1xjjqpQNVuPf9gVtfwDcTVywjHBUcLU8 Nbdoh8BhFrxO0MYkQMoqsWU3V25g6ss= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1623314218; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ldjzmlz6cIGfkfNrX2YwmWfxUK2Kb+bppA3zxB3fsc8=; b=/y43H0h3aFnFztu89zQaCTBy0JWzt2WMvpKOEVVxb15R5XXbMqvK81UAY2UNpgExH85c8G bT5GLhWmKIBlgzCQ== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 170D4A3B9A; Thu, 10 Jun 2021 08:36:57 +0000 (UTC) Date: Thu, 10 Jun 2021 10:36:57 +0200 Message-ID: From: Takashi Iwai To: Takashi Sakamoto Subject: Re: [PATCH v2 1/3] ALSA: pcm: add snd_pcm_period_elapsed() variant without acquiring lock of PCM substream In-Reply-To: <20210610082622.GA86308@workstation> References: <20210609143145.146680-1-o-takashi@sakamocchi.jp> <20210609143145.146680-2-o-takashi@sakamocchi.jp> <20210609231623.GA3207@workstation> <20210610080521.GA84899@workstation> <20210610082622.GA86308@workstation> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, clemens@ladisch.de X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 10 Jun 2021 10:26:22 +0200, Takashi Sakamoto wrote: > > On Thu, Jun 10, 2021 at 10:08:39AM +0200, Takashi Iwai wrote: > > On Thu, 10 Jun 2021 10:05:21 +0200, > > Takashi Sakamoto wrote: > > > > > > On Thu, Jun 10, 2021 at 09:39:37AM +0200, Takashi Iwai wrote: > > > > On Thu, 10 Jun 2021 01:16:23 +0200, > > > > Takashi Sakamoto wrote: > > > > > > > > > > On Wed, Jun 09, 2021 at 05:27:29PM +0200, Takashi Iwai wrote: > > > > > > On Wed, 09 Jun 2021 16:31:43 +0200, > > > > > > Takashi Sakamoto wrote: > > > > > > > diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c > > > > > > > index b7e3d8f44511..3488ec1e3674 100644 > > > > > > > --- a/sound/core/pcm_lib.c > > > > > > > +++ b/sound/core/pcm_lib.c > > > > > > > @@ -1778,27 +1778,41 @@ int snd_pcm_lib_ioctl(struct snd_pcm_substream *substream, > > > > > > > EXPORT_SYMBOL(snd_pcm_lib_ioctl); > > > > > > > > > > > > > > /** > > > > > > > - * snd_pcm_period_elapsed - update the pcm status for the next period > > > > > > > - * @substream: the pcm substream instance > > > > > > > + * snd_pcm_period_elapsed_under_stream_lock() - update the status of runtime for the next period > > > > > > > + * under acquired lock of PCM substream. > > > > > > > + * @substream: the instance of pcm substream. > > > > > > > + * > > > > > > > + * This function is called when the batch of audio data frames as the same size as the period of > > > > > > > + * buffer is already processed in audio data transmission. > > > > > > > + * > > > > > > > + * The call of function updates the status of runtime with the latest position of audio data > > > > > > > + * transmission, checks overrun and underrun over buffer, awaken user processes from waiting for > > > > > > > + * available audio data frames, sampling audio timestamp, and performs stop or drain the PCM > > > > > > > + * substream according to configured threshold. > > > > > > > + * > > > > > > > + * The function is intended to use for the case that PCM driver operates audio data frames under > > > > > > > + * acquired lock of PCM substream; e.g. in callback of any operation of &snd_pcm_ops in process > > > > > > > + * context. In any interrupt context, it's preferrable to use ``snd_pcm_period_elapsed()`` instead > > > > > > > + * since lock of PCM substream should be acquired in advance. > > > > > > > * > > > > > > > - * This function is called from the interrupt handler when the > > > > > > > - * PCM has processed the period size. It will update the current > > > > > > > - * pointer, wake up sleepers, etc. > > > > > > > + * Developer should pay enough attention that some callbacks in &snd_pcm_ops are done by the call of > > > > > > > + * function: > > > > > > > * > > > > > > > - * Even if more than one periods have elapsed since the last call, you > > > > > > > - * have to call this only once. > > > > > > > + * - .pointer - to retrieve current position of audio data transmission by frame count or XRUN state. > > > > > > > + * - .trigger - with SNDRV_PCM_TRIGGER_STOP at XRUN or DRAINING state. > > > > > > > + * - .get_time_info - to retrieve audio time stamp if needed. > > > > > > > + * > > > > > > > + * Even if more than one periods have elapsed since the last call, you have to call this only once. > > > > > > > + * > > > > > > > + * Context: Any context in which lock of PCM substream is already acquired. This function may not > > > > > > > + * sleep. > > > > > > > > > > > > Hm, this text still remains here. Overlooked? > > > > > > > > > > It's my intension for documentation of > > > > > snd_pcm_period_elapsed_under_stream_lock() since it's expected to call > > > > > it under acquired lock. Its implementation doesn't yield processor > > > > > voluntarily by itself. If it yielded, it would depend on implementation > > > > > of each driver for struct snd_pcm_ops.{pointer, trigger, get_time_info}, > > > > > but it's not preferable implementation of driver, in my opinion. > > > > > > > > My point is again about the sleep. This function may sleep in the > > > > nonatomic mode. The type of the PCM stream lock depends on it. > > > > > > Would I simply request you to show how the added function yields except > > > for the driver implementation? The lock of stream is expected to be > > > acquired already. > > > > In the nonatomic mode, the PCM stream lock is a mutex (no > > spin_lock_irqsave), hence it can sleep -- which contradicts with the > > added description above. > > > > Or do I misunderstand your question...? > > Thanks to clarify the role of PCM stream lock, and I'm ease that we have > the same understanding about the lock. > > Here, let us see deleted/added line again. > > > diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c > > index b7e3d8f44511..3488ec1e3674 100644 > > --- a/sound/core/pcm_lib.c > > +++ b/sound/core/pcm_lib.c > > @@ -1778,27 +1778,41 @@ int snd_pcm_lib_ioctl(struct snd_pcm_substream *substream, > > EXPORT_SYMBOL(snd_pcm_lib_ioctl); > > > > /** > > - * snd_pcm_period_elapsed - update the pcm status for the next period > > - * @substream: the pcm substream instance > > + * snd_pcm_period_elapsed_under_stream_lock() - update the status of runtime for the next period > > + * under acquired lock of PCM substream. > > + ... > > + * Context: Any context in which lock of PCM substream is already acquired. This function may not > > + * sleep. > > The issued documentation is for the new function. Inner the function, the > lock of PCM substream is not acquired again since it causes dead lock > (it's not nest-able lock) regardless of usage of mutex or spin_lock. > > The well-known function, snd_pcm_period_elapsed(), is rewritten to call > the new function between lock/unlock operations: > > ->snd_pcm_period_elapsed() > ->snd_pcm_stream_lock_irqsave() > ->snd_pcm_period_elapsed_under_stream_lock() > ->snd_pcm_stream_unlock_irqrestore() > > Or the new function can acquire the lock somewhere I overlook? However I > think it is unlikely since it necessarily causes dead lock or corruption > of irq context... Again, my *only* point is about the sleep. You addition was: + * Context: Any context in which lock of PCM substream is already acquired. This function may not + * sleep. where "This function may not sleep" is stated incorrectly. Takashi