From: Takashi Iwai <tiwai@suse.de>
To: Jeremy Szu <jeremy.szu@canonical.com>
Cc: "moderated list:SOUND" <alsa-devel@alsa-project.org>,
Kailang Yang <kailang@realtek.com>,
open list <linux-kernel@vger.kernel.org>,
Huacai Chen <chenhuacai@kernel.org>,
Jian-Hong Pan <jhp@endlessos.org>,
tiwai@suse.com, Hui Wang <hui.wang@canonical.com>,
PeiSen Hou <pshou@realtek.com>
Subject: Re: [PATCH 1/4] ALSA: hda/realtek: fix mute/micmute LEDs for HP 855 G8
Date: Thu, 27 May 2021 08:14:00 +0200 [thread overview]
Message-ID: <s5hpmxc900n.wl-tiwai@suse.de> (raw)
In-Reply-To: <CAKzWQkyzbUU8FekwX+_pkxSVFv0_1xjOQa7ztJRMR02cunP+tQ@mail.gmail.com>
On Thu, 27 May 2021 04:00:34 +0200,
Jeremy Szu wrote:
>
> Hi Takashi,
>
> Would you please help to review these quirks? Many thanks.
Sorry, it was overlooked.
Now applied all four patches. Thanks.
Takashi
>
>
> On Thu, May 20, 2021 at 1:04 AM Jeremy Szu <jeremy.szu@canonical.com> wrote:
> >
> > The HP EliteBook 855 G8 Notebook PC is using ALC285 codec which needs
> > ALC285_FIXUP_HP_MUTE_LED fixup to make it works. After applying the
> > fixup, the mute/micmute LEDs work good.
> >
> > Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com>
> > ---
> > sound/pci/hda/patch_realtek.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> > index 552e2cb73291..9d68f591c6bf 100644
> > --- a/sound/pci/hda/patch_realtek.c
> > +++ b/sound/pci/hda/patch_realtek.c
> > @@ -8291,6 +8291,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> > SND_PCI_QUIRK(0x103c, 0x87f7, "HP Spectre x360 14", ALC245_FIXUP_HP_X360_AMP),
> > SND_PCI_QUIRK(0x103c, 0x8846, "HP EliteBook 850 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
> > SND_PCI_QUIRK(0x103c, 0x884c, "HP EliteBook 840 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
> > + SND_PCI_QUIRK(0x103c, 0x8896, "HP EliteBook 855 G8 Notebook PC", ALC285_FIXUP_HP_MUTE_LED),
> > SND_PCI_QUIRK(0x103c, 0x8898, "HP EliteBook 845 G8 Notebook PC", ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST),
> > SND_PCI_QUIRK(0x1043, 0x103e, "ASUS X540SA", ALC256_FIXUP_ASUS_MIC),
> > SND_PCI_QUIRK(0x1043, 0x103f, "ASUS TX300", ALC282_FIXUP_ASUS_TX300),
> > --
> > 2.31.1
> >
>
>
> --
> Sincerely,
> Jeremy Su
>
next prev parent reply other threads:[~2021-05-27 6:15 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 17:03 [PATCH 1/4] ALSA: hda/realtek: fix mute/micmute LEDs for HP 855 G8 Jeremy Szu
2021-05-19 17:03 ` [PATCH 2/4] ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP Zbook G8 Jeremy Szu
2021-05-19 17:03 ` [PATCH 3/4] ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP Zbook Fury 15 G8 Jeremy Szu
2021-05-19 17:03 ` [PATCH 4/4] ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP Zbook Fury 17 G8 Jeremy Szu
2021-05-27 2:00 ` [PATCH 1/4] ALSA: hda/realtek: fix mute/micmute LEDs for HP 855 G8 Jeremy Szu
2021-05-27 6:14 ` Takashi Iwai [this message]
2022-01-11 19:52 ` Alexander Sergeyev
2022-01-12 9:45 ` Takashi Iwai
2022-01-12 10:12 ` Alexander Sergeyev
2022-01-12 10:13 ` Takashi Iwai
2022-01-12 10:48 ` Alexander Sergeyev
2022-01-12 20:18 ` Alexander Sergeyev
2022-01-13 7:14 ` Takashi Iwai
2022-01-13 18:31 ` Alexander Sergeyev
2022-01-13 21:19 ` Alexander Sergeyev
2022-01-14 16:37 ` Takashi Iwai
2022-01-14 18:37 ` Alexander Sergeyev
2022-01-15 7:55 ` Takashi Iwai
2022-01-15 15:22 ` Alexander Sergeyev
2022-01-19 9:12 ` Takashi Iwai
2022-01-19 9:32 ` Alexander Sergeyev
2022-01-22 19:05 ` Alexander Sergeyev
2022-01-22 20:56 ` Alexander Sergeyev
2022-01-26 15:24 ` Takashi Iwai
2022-01-29 14:47 ` Alexander Sergeyev
2022-01-30 11:10 ` Alexander Sergeyev
2022-01-31 14:57 ` Takashi Iwai
2022-02-05 15:00 ` Alexander Sergeyev
2022-02-05 17:51 ` Alexander Sergeyev
2022-02-07 14:21 ` Takashi Iwai
2022-02-08 19:49 ` Alexander Sergeyev
2022-02-08 14:36 ` Takashi Iwai
2022-02-08 19:52 ` Alexander Sergeyev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hpmxc900n.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=chenhuacai@kernel.org \
--cc=hui.wang@canonical.com \
--cc=jeremy.szu@canonical.com \
--cc=jhp@endlessos.org \
--cc=kailang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pshou@realtek.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).