From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6A36C47089 for ; Thu, 27 May 2021 06:15:16 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B3ABF613DC for ; Thu, 27 May 2021 06:15:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B3ABF613DC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 5447F1705; Thu, 27 May 2021 08:14:22 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 5447F1705 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1622096112; bh=u4DcIBpwEA4e/AqFM11zUp80Z+oJqBnIu32/raoYQzU=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=KlmenD3ybAEHf8p+8Ek8teoIlr+KiMVZ2zFC67h0WXTCfXCuXfCu58ryJDmBWLesK GI5zlDmcYOgfHGLX8Ip5glp/blD+/cHQHF6teyvYeGuEh0NuRNSeZR+HV3UGZhOkys t38ZWWHF4xlI9coqoKOkkahY/M3iEu6f6JS5zU3U= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id AD805F80116; Thu, 27 May 2021 08:14:21 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id DD244F8012E; Thu, 27 May 2021 08:14:18 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A1ED0F800EA for ; Thu, 27 May 2021 08:14:06 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A1ED0F800EA Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="msbNX5Ep"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="Vq3wzU65" X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1622096040; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0PohsSrFjqpl0gYvbtoAe9n4JF3cM3zBDn9ikvgJv98=; b=msbNX5EpKsQUDaxRwZMU+71+H9l8Yojm+vfRyvdkYJ6FGQDgrs1FmZlaZVq16zb4y2N5e3 +SMNKR8V0VDHr++yD4UwHr2Gonbb5G1uy1Xk2CkSO9wTpFDUI/xNk89WIY9zPJh2Eb4QGB 7K/6zfZhJhmgvvxAfbOVnHUx2JSxIHc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1622096040; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0PohsSrFjqpl0gYvbtoAe9n4JF3cM3zBDn9ikvgJv98=; b=Vq3wzU658mu9+GB7ynLVH5yJY7itKb9t+HSkFn7VW6YoSu4M+kwL/XSPTGNFRhwF69MWYm OnQXYh5FdiGU89DQ== Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id AE3F3AC46; Thu, 27 May 2021 06:14:00 +0000 (UTC) Date: Thu, 27 May 2021 08:14:00 +0200 Message-ID: From: Takashi Iwai To: Jeremy Szu Subject: Re: [PATCH 1/4] ALSA: hda/realtek: fix mute/micmute LEDs for HP 855 G8 In-Reply-To: References: <20210519170357.58410-1-jeremy.szu@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: "moderated list:SOUND" , Kailang Yang , open list , Huacai Chen , Jian-Hong Pan , tiwai@suse.com, Hui Wang , PeiSen Hou X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 27 May 2021 04:00:34 +0200, Jeremy Szu wrote: > > Hi Takashi, > > Would you please help to review these quirks? Many thanks. Sorry, it was overlooked. Now applied all four patches. Thanks. Takashi > > > On Thu, May 20, 2021 at 1:04 AM Jeremy Szu wrote: > > > > The HP EliteBook 855 G8 Notebook PC is using ALC285 codec which needs > > ALC285_FIXUP_HP_MUTE_LED fixup to make it works. After applying the > > fixup, the mute/micmute LEDs work good. > > > > Signed-off-by: Jeremy Szu > > --- > > sound/pci/hda/patch_realtek.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > > index 552e2cb73291..9d68f591c6bf 100644 > > --- a/sound/pci/hda/patch_realtek.c > > +++ b/sound/pci/hda/patch_realtek.c > > @@ -8291,6 +8291,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > > SND_PCI_QUIRK(0x103c, 0x87f7, "HP Spectre x360 14", ALC245_FIXUP_HP_X360_AMP), > > SND_PCI_QUIRK(0x103c, 0x8846, "HP EliteBook 850 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), > > SND_PCI_QUIRK(0x103c, 0x884c, "HP EliteBook 840 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), > > + SND_PCI_QUIRK(0x103c, 0x8896, "HP EliteBook 855 G8 Notebook PC", ALC285_FIXUP_HP_MUTE_LED), > > SND_PCI_QUIRK(0x103c, 0x8898, "HP EliteBook 845 G8 Notebook PC", ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST), > > SND_PCI_QUIRK(0x1043, 0x103e, "ASUS X540SA", ALC256_FIXUP_ASUS_MIC), > > SND_PCI_QUIRK(0x1043, 0x103f, "ASUS TX300", ALC282_FIXUP_ASUS_TX300), > > -- > > 2.31.1 > > > > > -- > Sincerely, > Jeremy Su >