From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18BE1C433E7 for ; Tue, 13 Oct 2020 16:35:27 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4D7D9252A7 for ; Tue, 13 Oct 2020 16:35:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="jm3n7Cjk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D7D9252A7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9C46D169E; Tue, 13 Oct 2020 18:34:32 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9C46D169E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1602606922; bh=hW+gZ3mX+I7TjzInjraqn47Hd+J05TcNPNYaRPcR7qs=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=jm3n7CjkZOrAXQaR8oLP7mQqSPM7CQNF/vrCLRdldOUUfgKZd9J6z5DIxKFPLlxlQ EafHqkv8KkaNOI4MeF1jSS55k3Q8dr1mT7C3e/qhDis7/dDedl9sGpVtWNGSFr8Ncz qkmWp4MKWlIpn8A08O6SD2ZK6YcFGtXN/YzvUvKk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2C32FF8016F; Tue, 13 Oct 2020 18:34:32 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0759CF801A3; Tue, 13 Oct 2020 18:34:30 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 24229F800CE for ; Tue, 13 Oct 2020 18:34:23 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 24229F800CE X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C131EAD2E; Tue, 13 Oct 2020 16:34:22 +0000 (UTC) Date: Tue, 13 Oct 2020 18:34:22 +0200 Message-ID: From: Takashi Iwai To: Kai Vehmanen Subject: Re: [PATCH] ALSA: hda/hdmi: fix incorrect locking in hdmi_pcm_close In-Reply-To: <20201013152628.920764-1-kai.vehmanen@linux.intel.com> References: <20201013152628.920764-1-kai.vehmanen@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 13 Oct 2020 17:26:28 +0200, Kai Vehmanen wrote: > > A race exists between closing a PCM and update of ELD data. In > hdmi_pcm_close(), hinfo->nid value is modified without taking > spec->pcm_lock. If this happens concurrently while processing an ELD > update in hdmi_pcm_setup_pin(), converter assignment may be done > incorrectly. > > This bug was found by hitting a WARN_ON in snd_hda_spdif_ctls_assign() > in a HDMI receiver connection stress test: > > [2739.684569] WARNING: CPU: 5 PID: 2090 at sound/pci/hda/patch_hdmi.c:1898 check_non_pcm_per_cvt+0x41/0x50 [snd_hda_codec_hdmi] > ... > [2739.684707] Call Trace: > [2739.684720] update_eld+0x121/0x5a0 [snd_hda_codec_hdmi] > [2739.684736] hdmi_present_sense+0x21e/0x3b0 [snd_hda_codec_hdmi] > [2739.684750] check_presence_and_report+0x81/0xd0 [snd_hda_codec_hdmi] > [2739.684842] intel_audio_codec_enable+0x122/0x190 [i915] > > Fixes: 42b2987079ec ("ALSA: hda - hdmi playback without monitor in dynamic pcm bind mode") > Signed-off-by: Kai Vehmanen Applied now. Thanks. Takashi