From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5792C433DF for ; Wed, 3 Jun 2020 09:42:11 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8942320734 for ; Wed, 3 Jun 2020 09:42:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="b8iABazd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8942320734 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 152761655; Wed, 3 Jun 2020 11:41:20 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 152761655 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1591177330; bh=biUk5xnNKFudU6VYyLjr7VrSfM/myZNtbFPfvkid1ko=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=b8iABazdh+hMJOmFNR8NXtf3OjazB3KPldN2AxIB+BSoZlU69NpWotnsMoKtBmqDi lFLyFDWBVA9k9dNUdJW8AlWkVIjMWyPVMYoKOmej6mwHz8Jz0k368yOXRtU1+BjPOv S2ttrdJyiXWqWzovmozKLFXZIzjMo9vrOPRpwznI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 85904F801F5; Wed, 3 Jun 2020 11:41:19 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 5A378F80212; Wed, 3 Jun 2020 11:41:18 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C9B8CF800BC for ; Wed, 3 Jun 2020 11:41:15 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C9B8CF800BC X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 4F378ACC5; Wed, 3 Jun 2020 09:41:18 +0000 (UTC) Date: Wed, 03 Jun 2020 11:41:14 +0200 Message-ID: From: Takashi Iwai To: Chuhong Yuan Subject: Re: [PATCH] ALSA: es1688: Add the missed snd_card_free() In-Reply-To: <20200603092459.1424093-1-hslester96@gmail.com> References: <20200603092459.1424093-1-hslester96@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: linux-kernel@vger.kernel.org, Krzysztof Helt , Takashi Iwai , alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 03 Jun 2020 11:24:59 +0200, Chuhong Yuan wrote: > > snd_es968_pnp_detect() misses a snd_card_free() in a failed path. > Add the missed function call to fix it. > > Fixes: a20971b201ac ("ALSA: Merge es1688 and es968 drivers") > Signed-off-by: Chuhong Yuan Thanks, applied now with Cc-to-stable. Takashi