From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 216BDC3A5A9 for ; Sat, 2 May 2020 10:10:13 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9DE4221835 for ; Sat, 2 May 2020 10:10:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="WupNTrmm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9DE4221835 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id E8F3516B0; Sat, 2 May 2020 12:09:20 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz E8F3516B0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1588414211; bh=bx19sZeuieZuhDDqfC3U4oRC3/sE1BpAqVQ0DPBHWhs=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=WupNTrmmMj3OIkPDkxWMlLM+OlAuakqq398zNJCaWE4QTJ0b0r1Q1Y4jcIXAKCEX2 c0Pv7lDRMe1jV9vn+mNt5/lrUof+l02/Rcx1ggiuDXX3yT/MGd3PMST/x71tPGGkqq 7NGFdZTiU88EcoRwipr+/H5Zhw8axZ4dF4ZuuaFw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 847DFF801EB; Sat, 2 May 2020 12:09:20 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 884BFF801F7; Sat, 2 May 2020 12:09:19 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B639FF800E5 for ; Sat, 2 May 2020 12:09:15 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B639FF800E5 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id A957AAED6; Sat, 2 May 2020 10:09:14 +0000 (UTC) Date: Sat, 02 May 2020 12:09:13 +0200 Message-ID: From: Takashi Iwai To: Nicholas Johnson Subject: Re: [PATCH 0/1] Fiji GPU audio register timeout when in BACO state In-Reply-To: References: <20200502071728.fn2fcqvt6aies3zu@wunner.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: "Zhou, David\(ChunMing\)" , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" , "amd-gfx@lists.freedesktop.org" , Takashi Iwai , "Deucher, Alexander" , Lukas Wunner , Alex Deucher , "Koenig, Christian" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sat, 02 May 2020 09:27:31 +0200, Takashi Iwai wrote: > > On Sat, 02 May 2020 09:17:28 +0200, > Lukas Wunner wrote: > > > > On Sat, May 02, 2020 at 09:11:58AM +0200, Takashi Iwai wrote: > > > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > > @@ -673,6 +673,12 @@ static int amdgpu_dm_audio_component_bind(struct device *kdev, > > > struct amdgpu_device *adev = dev->dev_private; > > > struct drm_audio_component *acomp = data; > > > > > > + if (!device_link_add(hda_kdev, kdev, DL_FLAG_STATELESS | > > > + DL_FLAG_PM_RUNTIME)) { > > > + DRM_ERROR("DM: cannot add device link to audio device\n"); > > > + return -ENOMEM; > > > + } > > > + > > > > Doesn't this duplicate drivers/pci/quirks.c:quirk_gpu_hda() ? > > Gah, you're right, that was the place I overlooked. > It was a typical "false Eureka right-after-wakeup" phenomenon :) > Need a vaccine aka coffee... > > So the runtime PM dependency must be already placed there, and the > problem is not the lack of the dependency tree but the really other > timing issue. Back to square. One interesting test is to open the stream while the mode isn't set yet and see whether the same problem appears. Namely, after the monitor is connected but no mode is set, run directly like aplay -Dhdmi:1,0 foo.wav You might need to wrap the command with pasuspender if PA is active. Takashi