From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6FFFCA9EA0 for ; Mon, 28 Oct 2019 06:28:42 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E369520873 for ; Mon, 28 Oct 2019 06:28:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="Yv1OswRc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E369520873 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 5F0401933; Mon, 28 Oct 2019 07:27:49 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 5F0401933 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1572244119; bh=Fo93pyfTo+DFcK+5sP0n6QYa52Mj2Iy3ee2+xV6Oiqg=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Yv1OswRckZBvSBdZjJ2SNn0+8rBNaD6r4ze5+P9Hg/cZB6O2sNbkP46vH1dHWgI89 BRHLUKXCCaZ3b1/ZU4wUePJHIS5CtdJhjphZiAYQXUp8geYeMJ+vWpEhB8yTB1DoBE 3EbUgHWb7lebww93FzDI0Vn0yX/jjCwsPDTU5QnY= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id D3489F802BD; Mon, 28 Oct 2019 07:27:48 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 28CE1F80361; Mon, 28 Oct 2019 07:27:47 +0100 (CET) Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 15DB2F800E7 for ; Mon, 28 Oct 2019 07:27:44 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 15DB2F800E7 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 98A3FAC24; Mon, 28 Oct 2019 06:27:42 +0000 (UTC) Date: Mon, 28 Oct 2019 07:27:40 +0100 Message-ID: From: Takashi Iwai To: Navid Emamdoost In-Reply-To: <20191027221007.14317-1-navid.emamdoost@gmail.com> References: <20191027221007.14317-1-navid.emamdoost@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Cc: alsa-devel@alsa-project.org, kjlu@umn.edu, Clemens Ladisch , Takashi Iwai , emamd001@umn.edu, smccaman@umn.edu, linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [PATCH] ALSA: usb-audio: Fix memory leak in __snd_usbmidi_create X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sun, 27 Oct 2019 23:10:06 +0100, Navid Emamdoost wrote: > > In the implementation of __snd_usbmidi_create() there is a memory leak > caused by incorrect goto destination. Go to free_midi if > snd_usbmidi_create_endpoints_midiman() or snd_usbmidi_create_endpoints() > fail. No, this will lead to double-free. After registering the rawmidi interface at snd_usbmidi_create_rawmidi(), the common destructor will be called via rawmidi private_free callback, and this will release the all resources already. thanks, Takashi > > Fixes: 731209cc0417 ("ALSA: usb-midi: Use common error handling code in __snd_usbmidi_create()") > Signed-off-by: Navid Emamdoost > --- > sound/usb/midi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/usb/midi.c b/sound/usb/midi.c > index b737f0ec77d0..22db37fbfbbd 100644 > --- a/sound/usb/midi.c > +++ b/sound/usb/midi.c > @@ -2476,7 +2476,7 @@ int __snd_usbmidi_create(struct snd_card *card, > else > err = snd_usbmidi_create_endpoints(umidi, endpoints); > if (err < 0) > - goto exit; > + goto free_midi; > > usb_autopm_get_interface_no_resume(umidi->iface); > > -- > 2.17.1 > _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel