From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH 2/2] ALSA: firewire-lib: fix to process MIDI conformant data channel for AM824 format Date: Fri, 28 Jun 2019 10:50:34 +0200 Message-ID: References: <20190628055331.1427-1-o-takashi@sakamocchi.jp> <20190628055331.1427-3-o-takashi@sakamocchi.jp> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 08A2FF89730 for ; Fri, 28 Jun 2019 10:50:35 +0200 (CEST) In-Reply-To: <20190628055331.1427-3-o-takashi@sakamocchi.jp> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" To: Takashi Sakamoto Cc: alsa-devel@alsa-project.org, clemens@ladisch.de List-Id: alsa-devel@alsa-project.org On Fri, 28 Jun 2019 07:53:31 +0200, Takashi Sakamoto wrote: > > In IEC 61883-6, 8 MIDI data streams are multiplexed into single MIDI > conformant data channel. The index of stream is calculated by modulo 8 > of the value of data block counter. Therefore data block processing > layer requires valid value of data block counter. > > In recent changes of ALSA IEC 61883-1/6 engine, the value of data block > counter is changed before calling data block processing layer. This > brings miss detection of MIDI messages in non-blocking transmission > method is used. > > This commit fixes the bug by changing chached data block counter after > calling data block processing layer. > > Fixes: e335425b6596 ("ALSA: firewire-lib: split helper function to check incoming CIP header") > Signed-off-by: Takashi Sakamoto Thanks, applied now. Takashi