From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH 6/7] ALSA: hda/tegra: fix kernel panic Date: Mon, 21 Jan 2019 22:28:26 +0100 Message-ID: References: <1548092497-5459-1-git-send-email-spujar@nvidia.com> <1548092497-5459-7-git-send-email-spujar@nvidia.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 7E42E2667E7 for ; Mon, 21 Jan 2019 22:28:27 +0100 (CET) In-Reply-To: <1548092497-5459-7-git-send-email-spujar@nvidia.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Sameer Pujar Cc: alsa-devel@alsa-project.org, broonie@kernel.org List-Id: alsa-devel@alsa-project.org On Mon, 21 Jan 2019 18:41:36 +0100, Sameer Pujar wrote: > > Kernel panic is seen during device boot. It appears that before the > probe completes, runtime callbacks happen and the device setup is not > done yet. This could be initiated from framework through exposed > callbacks. This issue can be fixed by having a flag to indicate > completion of device probe. Hence 'probed' flag is introduced to notify > completion of probe and runtime callbacks can check this flag before > doing any device access. Such a fix should be rather folded into the previous, especially if you know it's already broken :) And, IMO, it's better to put such a check into runtime_idle callback instead of doing in each (runtime_)suspend/resume callback. thanks, Takashi