From: Takashi Iwai <tiwai@suse.de>
To: "Amadeusz Sławiński" <amade@asmblr.net>
Cc: alsa-devel@alsa-project.org,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: usb-audio: fix CM6206 register definitions
Date: Tue, 08 Jan 2019 22:52:58 +0100 [thread overview]
Message-ID: <s5hpnt6izph.wl-tiwai@suse.de> (raw)
In-Reply-To: <20190108200311.4969-1-amade@asmblr.net>
On Tue, 08 Jan 2019 21:03:11 +0100,
Amadeusz Sławiński wrote:
>
> fix typo after a recent commit causing headphones to have no sound
>
> Fixes: ad43d528a7ac (ALSA: usb-audio: Define registers for CM6206)
> Signed-off-by: Amadeusz Sławiński <amade@asmblr.net>
> ---
> sound/usb/quirks.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
> index 96340f23f86d..ebbadb3a7094 100644
> --- a/sound/usb/quirks.c
> +++ b/sound/usb/quirks.c
> @@ -768,7 +768,7 @@ static int snd_usb_cm6206_boot_quirk(struct usb_device *dev)
> * REG1: PLL binary search enable, soft mute enable.
> */
> CM6206_REG1_PLLBIN_EN |
> - CM6206_REG1_SOFT_MUTE_EN |
> + CM6206_REG1_SOFT_MUTE_EN,
> /*
> * REG2: enable output drivers,
> * select front channels to the headphone output,
Argh, that's a nasty error, thanks for spotting out.
Applied now.
Takashi
next prev parent reply other threads:[~2019-01-08 21:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-08 20:03 [PATCH] ALSA: usb-audio: fix CM6206 register definitions Amadeusz Sławiński
2019-01-08 21:52 ` Takashi Iwai [this message]
2019-01-11 14:14 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hpnt6izph.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=amade@asmblr.net \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox