From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH] ASoC: pcm512x: Add ACPI support
Date: Fri, 18 May 2018 18:16:31 +0200
Message-ID: <s5hpo1thrc0.wl-tiwai@suse.de>
References: <20180517225326.30881-1-pierre-louis.bossart@linux.intel.com>
 <20180518043639.GF2932@vkoul-mobl>
 <e4567264-1362-7a9d-7883-5b5dd8f96c5d@linux.intel.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (mx2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id E759D267046
 for <alsa-devel@alsa-project.org>; Fri, 18 May 2018 18:16:32 +0200 (CEST)
In-Reply-To: <e4567264-1362-7a9d-7883-5b5dd8f96c5d@linux.intel.com>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: liam.r.girdwood@linux.intel.com, Vinod <vkoul@kernel.org>, broonie@kernel.org, Keyon Jie <yang.jie@linux.intel.com>, alsa-devel@alsa-project.org
List-Id: alsa-devel@alsa-project.org

On Fri, 18 May 2018 18:07:26 +0200,
Pierre-Louis Bossart wrote:
> 
> On 5/17/18 11:36 PM, Vinod wrote:
> > On 17-05-18, 17:53, Pierre-Louis Bossart wrote:
> >> HID is assumed to be made of TI PCI ID (0x104C) + part number, so all
> >> four 104C5121, 104C5122, 104C5141 104C5142 are valid.
> >>
> >> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> >> ---
> >
> > ...
> >
> >>   static struct i2c_driver pcm512x_i2c_driver = {
> >>   	.probe 		= pcm512x_i2c_probe,
> >> @@ -67,7 +81,8 @@ static struct i2c_driver pcm512x_i2c_driver = {
> >>   	.id_table	= pcm512x_i2c_id,
> >>   	.driver		= {
> >>   		.name	= "pcm512x",
> >> -		.of_match_table = pcm512x_of_match,
> >> +		.of_match_table = of_match_ptr(pcm512x_of_match),
> >
> > this change may not be part of this and should be mentioned in the log
> >
> > Also quick grep tells me kernel has both :(
> 
> I don't get your point. This is how we've added support for ACPI for
> every codec so far, and using those macros is the way to make sure the
> DT case still builds and isn't impacted.

Well, my interpretation is that this change is needed to allow the
driver built without CONFIG_OF, and it's not only about ACPI, per se.


Takashi