From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] input/keyboard: fix platform_no_drv_owner.cocci warnings Date: Sun, 20 Aug 2017 22:35:55 +0200 Message-ID: References: <20170820162841.GA1176@dtor-ws> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <20170820162841.GA1176@dtor-ws> Sender: linux-input-owner@vger.kernel.org To: Dmitry Torokhov Cc: Julia Lawall , alsa-devel@alsa-project.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, kbuild-all@01.org List-Id: alsa-devel@alsa-project.org On Sun, 20 Aug 2017 18:28:41 +0200, Dmitry Torokhov wrote: > > On Sun, Aug 20, 2017 at 11:19:38AM +0200, Julia Lawall wrote: > > No need to set .owner here. The core will do it. > > > > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci > > > > Fixes: 52cf590518d7 ("input/keyboard: Add support for Dollar Cove TI power button") > > Signed-off-by: Julia Lawall > > Signed-off-by: Fengguang Wu > > --- > > > > dc_ti_pwrbtn.c | 1 - > > Hm, this driver is neither in my tree nor in next; where is it coming > from? It's only in my tree for testing, but kbuild bot takes all branches unconditionally, so... In anyway, I hope I can submit sooner or later :) Takashi > > > 1 file changed, 1 deletion(-) > > > > --- a/drivers/input/keyboard/dc_ti_pwrbtn.c > > +++ b/drivers/input/keyboard/dc_ti_pwrbtn.c > > @@ -75,7 +75,6 @@ static int dc_ti_pwrbtn_probe(struct pla > > static struct platform_driver dc_ti_pwrbtn_driver = { > > .driver = { > > .name = DRIVER_NAME, > > - .owner = THIS_MODULE, > > }, > > .probe = dc_ti_pwrbtn_probe, > > }; > > -- > Dmitry >