From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH 0/6] ALSA: firewire: simplify symbol space
	for local linkage
Date: Wed, 04 Jan 2017 11:39:11 +0100
Message-ID: <s5hpok3qfcg.wl-tiwai@suse.de>
References: <20170103124121.17143-1-o-takashi@sakamocchi.jp>
 <s5hwpecm1c0.wl-tiwai@suse.de>
 <387d35ad-0261-689f-8680-af68351d87a6@sakamocchi.jp>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (mx2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id E7E0A267026
 for <alsa-devel@alsa-project.org>; Wed,  4 Jan 2017 11:39:12 +0100 (CET)
In-Reply-To: <387d35ad-0261-689f-8680-af68351d87a6@sakamocchi.jp>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: alsa-devel@alsa-project.org, clemens@ladisch.de
List-Id: alsa-devel@alsa-project.org

On Wed, 04 Jan 2017 11:36:10 +0100,
Takashi Sakamoto wrote:
> 
> Hi,
> 
> On Jan 4 2016 03:43, Takashi Iwai wrote:
> > On Tue, 03 Jan 2017 13:41:15 +0100,
> > Takashi Sakamoto wrote:
> >>
> >> Hi,
> >>
> >> This patchset is just for code improvements, without adding features.
> >>
> >> Modules in ALSA firewire stack have some implementations for operation
> >> structures which sound subsystem defines. All of them are referred just by
> >> each local function to register corresponding operations. In this case, it's
> >> better to put them into the function local so that symbol space in local
> >> linkage of translation unit is kept to be simple.
> >
> > Do we see any merit in the resultant binaries by these changes?
> > I'm not against this kind of code changes, but just wondered.
> > That is, it's not totally clear what you takes as really "better" in
> > your context.
> 
> Mmm, sorry but my explanation is wrong. I managed to describe the
> reason in an aspect of local linkage, but an aim of this patchset is
> irrelevant to it.
> 
> The aim is for identifier space of each translation unit. The merit
> can be described in two points:
>  - For readers
>   - readers have no concern about where the identifier is referred.
>     It's just inner the including function.
>  - For identifier space of the file
>   - developers are free from name conflict for further work.
> 
> If no objections against the aim, I'll resubmit this patchset with
> proper commit comments.

Yes, please go ahead.


thanks,

Takashi