alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai-l3A5Bk7waGM@public.gmane.org>
To: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
	Alexandre Courbot
	<gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Dylan Reid <dgreid-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/6] ALSA: hda/tegra - Set CORBRP self-clear flag
Date: Sat, 09 May 2015 07:58:19 +0200	[thread overview]
Message-ID: <s5hpp6agumc.wl-tiwai@suse.de> (raw)
In-Reply-To: <1430830584-3113-1-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

At Tue,  5 May 2015 14:56:19 +0200,
Thierry Reding wrote:
> 
> From: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> 
> This is set for the MCP variants of the NVIDIA HDA controller, which the
> Tegra variant was derived from. This fixes the following warning at boot
> time:
> 
> 	[    2.486610] tegra-hda 70030000.hda: CORB reset timeout#1, CORBRP = 0
> 
> Signed-off-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

Since I've been traveling in this and next weeks, I'll check and apply
this series after my vacation although they look good at a quick
glance.


thanks,

Takashi

> ---
>  sound/pci/hda/hda_tegra.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/pci/hda/hda_tegra.c b/sound/pci/hda/hda_tegra.c
> index db0bb50fa5b9..7003677f7473 100644
> --- a/sound/pci/hda/hda_tegra.c
> +++ b/sound/pci/hda/hda_tegra.c
> @@ -460,11 +460,12 @@ MODULE_DEVICE_TABLE(of, hda_tegra_match);
>  
>  static int hda_tegra_probe(struct platform_device *pdev)
>  {
> +	const unsigned int driver_flags = AZX_DCAPS_RIRB_DELAY |
> +					  AZX_DCAPS_CORBRP_SELF_CLEAR;
>  	struct snd_card *card;
>  	struct azx *chip;
>  	struct hda_tegra *hda;
>  	int err;
> -	const unsigned int driver_flags = AZX_DCAPS_RIRB_DELAY;
>  
>  	hda = devm_kzalloc(&pdev->dev, sizeof(*hda), GFP_KERNEL);
>  	if (!hda)
> -- 
> 2.3.5
> 

  parent reply	other threads:[~2015-05-09  5:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-05 12:56 [PATCH 1/6] ALSA: hda/tegra - Set CORBRP self-clear flag Thierry Reding
     [not found] ` <1430830584-3113-1-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-05-05 12:56   ` [PATCH 2/6] ALSA: hda/hdmi - Implement Tegra-specific patch Thierry Reding
2015-05-05 12:56   ` [PATCH 3/6] ALSA: hda/tegra - Improve error reporting Thierry Reding
2015-05-05 12:56   ` [PATCH 4/6] ALSA: hda/hdmi - Add Tegra30 support Thierry Reding
2015-05-05 12:56   ` [PATCH 5/6] ALSA: hda/hdmi - Add Tegra114 support Thierry Reding
2015-05-05 12:56   ` [PATCH 6/6] ALSA: hda/hdmi - Add Tegra210 support Thierry Reding
2015-05-09  5:58   ` Takashi Iwai [this message]
2015-05-18  8:04   ` [PATCH 1/6] ALSA: hda/tegra - Set CORBRP self-clear flag Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hpp6agumc.wl-tiwai@suse.de \
    --to=tiwai-l3a5bk7wagm@public.gmane.org \
    --cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
    --cc=dgreid-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
    --cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).