From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH v4 0/7] ASoC: add CSR SiRFSoC sound drivers Date: Thu, 27 Feb 2014 09:09:21 +0100 Message-ID: References: <1393394695-29735-1-git-send-email-rongjun.ying@csr.com> <20140227043856.GI9383@sirena.org.uk> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id A11042657D4 for ; Thu, 27 Feb 2014 09:09:22 +0100 (CET) In-Reply-To: <20140227043856.GI9383@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: alsa-devel@alsa-project.org, Liam Girdwood , workgroup.linux@csr.com, Rongjun Ying , RongJun Ying List-Id: alsa-devel@alsa-project.org At Thu, 27 Feb 2014 13:38:56 +0900, Mark Brown wrote: > > On Wed, Feb 26, 2014 at 07:35:12AM +0100, Takashi Iwai wrote: > > > Are there anything else you want to say except for these subject > > lines? The empty changelog for such big changes doesn't look good. > > For new drivers it's more acceptable, though - if the driver isn't doing > anything exciting (and a lot of them won't be) there's often not much to > say. A lot of the changelogs you see are just a bit of the marketing > blurb from the datasheet. True, but it may be still useful for reviewing. At least, you can know the expected hardware features provided by the driver in the changelog before you start reviewing. Otherwise you have no clue whether it's implementing the right thing. Takashi