From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH 1/2] ALSA: hda/ca0132 - setup/cleanup streams
Date: Fri, 07 Feb 2014 12:12:30 +0100
Message-ID: <s5hppmztbvl.wl%tiwai@suse.de>
References: <1391744130-15043-1-git-send-email-hychao@chromium.org>
	<s5hvbwrtchj.wl%tiwai@suse.de>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <s5hvbwrtchj.wl%tiwai@suse.de>
Sender: linux-kernel-owner@vger.kernel.org
To: Hsin-Yu Chao <hychao@chromium.org>
Cc: linux-arm-kernel@lists.infradead.org, Jaroslav Kysela <perex@perex.cz>, Dylan Reid <dgreid@chromium.org>, Chih-Chung Chang <chihchung@chromium.org>, Xi Wang <xi.wang@gmail.com>, Ian Minett <ian_minett@creativelabs.com>, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
List-Id: alsa-devel@alsa-project.org

At Fri, 07 Feb 2014 11:59:20 +0100,
Takashi Iwai wrote:
>=20
> At Fri,  7 Feb 2014 11:35:29 +0800,
> Hsin-Yu Chao wrote:
> >=20
> > When a HDMI stream is opened with the same stream tag
> > as a following opened stream to ca0132, audio will be
> > heard from two ports simultaneously.
> > Fix this issue by change to use snd_hda_codec_setup_stream
> > and snd_hda_codec_cleanup_stream instead, so that an
> > inactive stream can be marked as 'dirty' when found
> > with a conflict stream tag, and then get purified.
> >=20
> > Signed-off-by: Hsin-Yu Chao <hychao@chromium.org>
> > Reviewed-by: Chih-Chung Chang <chihchung@chromium.org>
>=20
> Thanks, applied this one.

Hrm, not good.

sound/pci/hda/patch_ca0132.c: In function =E2=80=98ca0132_playback_pcm_=
prepare=E2=80=99:
sound/pci/hda/patch_ca0132.c:2675:2: error: implicit declaration of fun=
ction =E2=80=98ca0132_toggle_dac_format=E2=80=99 [-Werror=3Dimplicit-fu=
nction-declaration]
  ca0132_toggle_dac_format(codec);
  ^

Please give a patch that really builds and works cleanly with the
upstream code!


thanks,

Takashi