Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Herton Ronaldo Krzesinski <herton@mandriva.com.br>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: hda - Fix ALC660-VD/ALC861-VD capture/playback mixers
Date: Thu, 25 Nov 2010 10:21:52 +0100	[thread overview]
Message-ID: <s5hpqttpxlb.wl%tiwai@suse.de> (raw)
In-Reply-To: <20101125000801.3933b48b@mandriva.com.br>

At Thu, 25 Nov 2010 00:08:01 -0200,
Herton Ronaldo Krzesinski wrote:
> 
> The mixer nids passed to alc_auto_create_input_ctls are wrong: 0x15 is
> a pin, and 0x09 is the ADC on both ALC660-VD/ALC861-VD. Thus with
> current code, input playback volume/switches and input source mixer
> controls are not created, and recording doesn't work. Select correct
> mixers, 0x0b (input playback mixer) and 0x22 (capture source mixer).
> 
> Reference: https://qa.mandriva.com/show_bug.cgi?id=61159
> 
> Signed-off-by: Herton Ronaldo Krzesinski <herton@mandriva.com.br>

Applied now.  Thanks!


Takashi

> ---
>  sound/pci/hda/patch_realtek.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index b4b3afe..5aafae9 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -16952,7 +16952,7 @@ static struct alc_config_preset alc861vd_presets[] = {
>  static int alc861vd_auto_create_input_ctls(struct hda_codec *codec,
>  						const struct auto_pin_cfg *cfg)
>  {
> -	return alc_auto_create_input_ctls(codec, cfg, 0x15, 0x09, 0);
> +	return alc_auto_create_input_ctls(codec, cfg, 0x0b, 0x22, 0);
>  }
>  
>  
> -- 
> 1.7.3.2
> 

      reply	other threads:[~2010-11-25  9:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-25  2:08 [PATCH] ALSA: hda - Fix ALC660-VD/ALC861-VD capture/playback mixers Herton Ronaldo Krzesinski
2010-11-25  9:21 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hpqttpxlb.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=herton@mandriva.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox