Re: Memleak with mixer? Or incorrect code?

[Takashi Iwai <tiwai@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 555 bytes --]

At Wed, 12 Jan 2005 12:23:20 +0100,
Reimar Döffinger wrote:
> 
> Hi,
> the attached code consumes more and more memory when I run it (with alsa
> 1.0.3 as included in SuSE 9.1).
> Why is that so? Did I forget to free something?
> Both commenting out the snd_mixer_selem_register or the snd_mixer_load
> call will fix it, but that's not an option in real code (this is
> actually a stripped-down version of the code in MPlayer's ao_alsa.c)...
> Any hints on that??

Yep, it hits a memory leak bug.
The patch below should fix it.


Takashi

[-- Attachment #2: Type: text/plain, Size: 465 bytes --]

Index: alsa-lib/src/mixer/bag.c
===================================================================
RCS file: /suse/tiwai/cvs/alsa/alsa-lib/src/mixer/bag.c,v
retrieving revision 1.4
diff -u -r1.4 bag.c
--- alsa-lib/src/mixer/bag.c	2 Jan 2002 12:01:22 -0000	1.4
+++ alsa-lib/src/mixer/bag.c	13 Jan 2005 16:53:44 -0000
@@ -59,6 +59,7 @@
 		bag1_t *b = list_entry(pos, bag1_t, list);
 		if (b->ptr == ptr) {
 			list_del(&b->list);
+			free(b);
 			return 0;
 		}
 	}