Re: EMU10K1 - CVS: nasty "click" at end of WAV files, and spurious extra modules.

[Takashi Iwai <tiwai@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 616 bytes --]

At Thu, 30 Jan 2003 00:11:00 +0000 (GMT),
Chris Rankin wrote:
> 
> Hi,
> 
> I have just installed the latest ALSA-CVS and I have
> noticed a few oddities:
> 
> First, these modules are suddenly being compiled. I
> don't know why:
> 
> snd-emu8000-synth.o
> snd-gus-synth.o
> snd-trident-synth.o

because of the last changes of Makefiles...
will be fixed soon.

> More importantly, playing WAV files via my SB Live!
> using aplay is making a nasty, loud "click" sound
> right at the end. It didn't used to do this. Any idea
> which change is causing it, please?

does the attached patch have any influence?


Takashi

[-- Attachment #2: sgbuf-clear.dif --]
[-- Type: application/octet-stream, Size: 435 bytes --]

Index: alsa-driver/acore/pcm_sgbuf.c
===================================================================
RCS file: /suse/tiwai/cvs/alsa/alsa-driver/acore/pcm_sgbuf.c,v
retrieving revision 1.7
diff -u -r1.7 pcm_sgbuf.c
--- alsa-driver/acore/pcm_sgbuf.c	27 Jan 2003 11:05:04 -0000	1.7
+++ alsa-driver/acore/pcm_sgbuf.c	30 Jan 2003 09:34:10 -0000
@@ -146,6 +146,7 @@
 #endif
 	}
 
+	memset(vmaddr, 0, size);
 	return vmaddr;
 
  _failed: