alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Geraldo Nascimento <geraldogabriel@gmail.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] snd-usb-audio: fix comment reference in __uac_clock_find_source
Date: Tue, 28 Sep 2021 10:46:44 +0200	[thread overview]
Message-ID: <s5hr1d9nl3f.wl-tiwai@suse.de> (raw)
In-Reply-To: <YU6Kj05oOqRmhJDf@geday>

On Sat, 25 Sep 2021 04:33:51 +0200,
Geraldo Nascimento wrote:
> 
> snd_usb_find_clock_source and snd_usb_find_clock_selector are helper macros that
> look at an entity id and validate that this entity id is in fact a clock source
> or a clock selector. The present comments inside __uac_clock_find_source give
> the reader the impression we're looking for an entity id.
> 
> We're looking for an entity id indeed, the clock source, but since
> __uac_clock_find_source is recursive, we're also looking *at* the entity ids,
> in the search for the one clock source.
> 
> Fix the comment so we don't give readers a wrong idea.
> 
> Signed-off-by: Geraldo Nascimento <geraldogabriel@gmail.com>

The patch couldn't be applied cleanly likely because your MUA
malformed the spaces.  As the change itself is pretty trivial, I
applied manually now.  But, please fix your MUA setup at the next
submission.

Thanks!


Takashi

      reply	other threads:[~2021-09-28  8:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-25  2:33 [PATCH] snd-usb-audio: fix comment reference in __uac_clock_find_source Geraldo Nascimento
2021-09-28  8:46 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hr1d9nl3f.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=geraldogabriel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).