From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81B79C433DB for ; Tue, 2 Mar 2021 17:24:03 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0171A64F34 for ; Tue, 2 Mar 2021 17:24:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0171A64F34 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 6954A18C6; Tue, 2 Mar 2021 18:23:10 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 6954A18C6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1614705840; bh=mBz1v6BVuLgqqbm/Ntbo2Urg7L9nU3Nb4gc/qGCMCgg=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=fiYfUja5lyfRuOwAox8NkGUZestef4joDRrmHbF2uTkI52upFCZ57WH5ndJ0b4tMK l9v6kcpVuVnGYxkdGxnFYBhHzLP2glo9w4ewl+w5q1Akz0+ryp5dw/lDBnbfUV62g6 7pWpT6tpa4POHhnWHhp6o1aryTzqk9dF5vv07sSc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id F17D8F80271; Tue, 2 Mar 2021 18:23:09 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A6B02F80273; Tue, 2 Mar 2021 18:23:08 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 226B1F8025B for ; Tue, 2 Mar 2021 18:23:05 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 226B1F8025B X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E00FFAE72; Tue, 2 Mar 2021 17:23:03 +0000 (UTC) Date: Tue, 02 Mar 2021 18:23:03 +0100 Message-ID: From: Takashi Iwai To: Mark Brown Subject: Re: [PATCH] ASoC: soc-core: Prevent warning if no DMI table is present In-Reply-To: <20210302124913.GC4522@sirena.org.uk> References: <20210302092712.310705-1-jonathanh@nvidia.com> <20210302124913.GC4522@sirena.org.uk> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Liam Girdwood , Jon Hunter X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 02 Mar 2021 13:49:13 +0100, Mark Brown wrote: > > On Tue, Mar 02, 2021 at 09:27:12AM +0000, Jon Hunter wrote: > > Many systems do not provide a DMI table and on these systems a warning, > > such as the following, is printed on boot ... > > > > WARNING KERN tegra-audio-graph-card sound: ASoC: no DMI vendor name! > > > > If DMI support is enabled in the kernel, there is no simple way to > > detect if a DMI table is table or not. Note that the variable > > 'dmi_available' is not exported and so cannot be used by kernel modules. > > We could fix that, or provide an accessor function? Or only warn if > we're on an ACPI system (which we can check from a module). This really > does feel like something we should be warning about on systems that are > supposed to have DMI information available as standard. I had the same feeling when I took a look at the patch, but later changed mind, since the error will pop up also if a system has an unmatured BIOS with some bogus vendor DMI string, too. That is, users of such a machine gets always an error message although this isn't any serious problem unless you need a dedicated UCM profile (which can't be used on such a system in anyway). So, I agree that exporting dmi_avilable could improve the situation a bit, but the error level needs still reconsideration. Takashi