From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59F53C433E0 for ; Tue, 7 Jul 2020 08:29:13 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC26D206DF for ; Tue, 7 Jul 2020 08:29:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="mktuc9b2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC26D206DF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 68A1F1697; Tue, 7 Jul 2020 10:28:21 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 68A1F1697 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1594110551; bh=sc/12Nc5u7PgU5UuZ+0asw2i3NVYab69GnFx+/Lck6A=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=mktuc9b236bTD++GJVY0Ur9oHf/ZvDhPQIrRRFi7vNQ7Xq2q92/5WLCqtkRoDD+YV AjZM8VLupHHA+7h+qh1vXEZkONIbGYWeMTc4VNB4WsSU3LCl3SQ/m7zVWiKP7lbzm4 Jo8t2zHv9LyMOShtXo4dTGcQBZ24jSJenjtVt67s= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 0B1A9F80264; Tue, 7 Jul 2020 10:28:21 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 76D53F80264; Tue, 7 Jul 2020 10:28:19 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D5912F801F9 for ; Tue, 7 Jul 2020 10:28:16 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D5912F801F9 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C11CAAFF7; Tue, 7 Jul 2020 08:28:16 +0000 (UTC) Date: Tue, 07 Jul 2020 10:28:16 +0200 Message-ID: From: Takashi Iwai To: Mark Hills Subject: Re: [PATCH 1/4] echoaudio: Race conditions around "opencount" In-Reply-To: <2007021037270.2435@stax.localdomain> References: <20200701122723.17814-1-mark@xwax.org> <202007020108.pW8giznF%lkp@intel.com> <2007021037270.2435@stax.localdomain> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 02 Jul 2020 11:53:51 +0200, Mark Hills wrote: > > Takashi, my apologies, it looks like this patch broke the build of the > Mona driver. > > Thankfully the change is simple, as it just looks like a bit of confusion > of responsibilies in the code for the Mona interface; the correct fix is > to remove the code. > > That is a lesson for working with only the echo3g driver enabled. Now I > have done a full build of all echoaudio drivers, with no warnings or > errors. > > Here's a patch, or it can be squashed into the original patch if > necessary. Could you rather fold the fix into the patch and resubmit the whole patch set? I'm just back from travel, and it'd be better anyway if I receive a fresh patch set to apply. Thanks! Takashi