From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED626C43603 for ; Thu, 12 Dec 2019 18:43:45 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D6442253D for ; Thu, 12 Dec 2019 18:43:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="HnTX2MUn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D6442253D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 965C0170D; Thu, 12 Dec 2019 19:42:53 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 965C0170D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1576176223; bh=5F4dr6++c8EeDHS1FU9/QrM9U1KZujuktXToNx956eo=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=HnTX2MUnwCN+FH0TjUmgGb00IpFBuyZ9W9EtFNU8FJ05EhPe5E0fX9unaNXNbftzr S7eZlU5DU0PBe9HxKyb4O/gvfoOtsfHESSdwixWjJNNBam88VRJxa5z4NBxlJ7u56R lbWTkTI6U+mAcj4j1zaoOiBKX9pnsPM+3fncSgAo= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2D0C0F8020C; Thu, 12 Dec 2019 19:42:53 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id CE156F80232; Thu, 12 Dec 2019 19:42:51 +0100 (CET) Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 307BEF80139 for ; Thu, 12 Dec 2019 19:42:48 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 307BEF80139 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 3DE78B011; Thu, 12 Dec 2019 18:42:48 +0000 (UTC) Date: Thu, 12 Dec 2019 19:42:48 +0100 Message-ID: From: Takashi Iwai To: Kai Vehmanen In-Reply-To: References: <20191210145727.22054-1-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Cc: alsa-devel@alsa-project.org Subject: Re: [alsa-devel] [PATCH] ALSA: hda: Use standard waitqueue for RIRB wakeup X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 12 Dec 2019 18:23:08 +0100, Takashi Iwai wrote: > > On Thu, 12 Dec 2019 18:17:14 +0100, > Kai Vehmanen wrote: > > > > Hey, > > > > On Tue, 10 Dec 2019, Takashi Iwai wrote: > > > > > This patch attempts to improve the situation by introducing the > > > standard waitqueue in the RIRB waiter side instead of polling. The > > > > this seems like a good change. It's a bit unfortunate this logic is not > > yet shared and SOF uses the variant in snd_hdac_bus_get_response() -- that > > would need similar treatment. I can make a matching change there and see > > how this fairs in SOF CI. But basic tests with snd-hda-intel on a few > > systems didn't reveal anything odd and code seems correct. > > Yes, please, the adaption to SOF is really appreciated. > This is a 5.6 material and I applied only the changes I could actually > test as a start. And now I realized that adapting this for the common code is trivial, and it's a good chance to unify the code there. I'll submit a test patch set soon later. Stay tuned. Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel