From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6119C432C3 for ; Fri, 15 Nov 2019 10:31:26 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4CB4E206C0 for ; Fri, 15 Nov 2019 10:31:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="oRcOUlj2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4CB4E206C0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 79820167A; Fri, 15 Nov 2019 11:30:34 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 79820167A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1573813884; bh=qSiebwJ5pe56JYx1YIYvgg7WXMRnSUpaAVnUIQkZXI0=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=oRcOUlj233JuJB08Cs6wjr7keHRhOoHOvC+8mN4k9vv53trXtReH2WvuaIYYL1+jH LboPooMX+nhzUxElZX1w2egCMvQgdWpKyTOFbyy/Qd60CVgHCdcJ7l723bDOUoLzLP i6dtqmHy2FJ2kLIwFeCSYxvx/+Hx8/Ml2XOjZLHg= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 09BFEF80103; Fri, 15 Nov 2019 11:30:14 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id DCB9DF80104; Fri, 15 Nov 2019 11:30:12 +0100 (CET) Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 3D971F800FF for ; Fri, 15 Nov 2019 11:30:09 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 3D971F800FF X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id CE730B278; Fri, 15 Nov 2019 10:30:08 +0000 (UTC) Date: Fri, 15 Nov 2019 11:30:08 +0100 Message-ID: From: Takashi Iwai To: Nikhil Mahale In-Reply-To: <5eb1ef50-e129-c188-0996-cd74de6a5025@nvidia.com> References: <20191114033704.18171-1-nmahale@nvidia.com> <20191114033704.18171-4-nmahale@nvidia.com> <9a6f7ac2-998f-23ff-c606-a780c4804eba@nvidia.com> <5eb1ef50-e129-c188-0996-cd74de6a5025@nvidia.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Cc: alsa-devel@alsa-project.org, tiwai@suse.com, aplattner@nvidia.com Subject: Re: [alsa-devel] [PATCH v1 3/5] ALSA: hda - Add DP-MST conn list support X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 15 Nov 2019 10:52:30 +0100, Nikhil Mahale wrote: > > On 11/14/19 6:44 PM, Takashi Iwai wrote: > > On Thu, 14 Nov 2019 12:47:36 +0100, > > Nikhil Mahale wrote: > >> > >> On 11/14/19 4:27 PM, Takashi Iwai wrote: > >>> On Thu, 14 Nov 2019 04:37:02 +0100, > >>> Nikhil Mahale wrote: > >>>> > >>>> Document change notification HDA040-A for the Intel High Definition > >>>> Audio 1.0a specification introduces a Device Select verb for Digital > >>>> Display Pin Widgets that are multi-stream capable. This verb selects > >>>> a Device Entry that is used by subsequent Pin Widget verbs, > >>>> including the Get Connection List Entry verb. > >>>> > >>>> This patch queries the current Device Select value, associates it > >>>> with the connection list, and updates the connection list management > >>>> code to consider dev_id along with nid. > >>> > >>> I don't get why this is needed. This is the list that is added only > >>> from snd_hda_override_conn_list(), and you don't change that call > >>> pattern, so dev_id is always zero. > >> > >> In follow-on patch "ALSA: hda - Add DP-MST support for non-acomp codecs", > >> hdmi_read_pin_conn() calls into snd_hda_set_dev_select() before > >> running into code path - > >> > >> snd_hda_get_connections() > >> |-> snd_hda_get_conn_list() > >> |-> read_and_add_raw_conns() > >> |-> snd_hda_override_conn_list() > >> |-> add_conn_list() > >> > >> If I understand spec correctly, conn_list need to read/write/track > >> along with device entry set into AC_VERB_SET_DEVICE_SEL verb, right? > > > > AFAIK, the device connection list itself is same no matter which > > device entry is. The pin widget may choose the route per device > > entry, but the available routes should be same. > > Section 7.3.3.42 of https://www.intel.com/content/dam/www/public/us/en/documents/specification-updates/high-definition-audio-multi-stream.pdf says that 'Get Connection List Entry' control should be per-device! Hrm, right. It's a bit concern that this may lead to the unlimited number of data, though. Since the necessity is only for HDMI codec, if that's the only place we need the connection list, the call there can be replaced with snd_hda_get_raw_connections() so that the result won't be cached in HD-audio core side. Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel