From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED8A1C432C3 for ; Thu, 14 Nov 2019 10:39:02 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E803C206D9 for ; Thu, 14 Nov 2019 10:39:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="k1kuyOK3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E803C206D9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A84A8839; Thu, 14 Nov 2019 11:38:09 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A84A8839 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1573727939; bh=3Ho9saoJtL2JleHgUp32NAgqbbG/i6a/5AtilkqMkq0=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=k1kuyOK3zLTB/C7rZ/EP9jYn7RAj4+U7HO/vpH9Qg9YSmZnjv1QIckAAoAecKct87 QVlII4U3vLfNtFzLP4HL8zegd4wbxCZIvGdrgyuh/7ukFZcxgW3CxDihM8t4MBbb3q bEq3nkVoPQbRHNq+C7i1Q5FZvUKlw0MHxsbwcJsY= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 40312F8007E; Thu, 14 Nov 2019 11:38:09 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 129F6F800CF; Thu, 14 Nov 2019 11:38:07 +0100 (CET) Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1B82BF8007E for ; Thu, 14 Nov 2019 11:38:03 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1B82BF8007E X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 9CF58ACB4; Thu, 14 Nov 2019 10:38:02 +0000 (UTC) Date: Thu, 14 Nov 2019 11:38:02 +0100 Message-ID: From: Takashi Iwai To: Nikhil Mahale In-Reply-To: <20191114033704.18171-1-nmahale@nvidia.com> References: <20191114033704.18171-1-nmahale@nvidia.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Cc: alsa-devel@alsa-project.org, tiwai@suse.com, aplattner@nvidia.com Subject: Re: [alsa-devel] [PATCH v1 0/5] ALSA: hda - Add DP-MST support for NVIDIA codecs X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 14 Nov 2019 04:36:59 +0100, Nikhil Mahale wrote: > > Today, DisplayPort multi-stream transport (DP-MST) audio is not > supported on codec drivers which don't use the audio component > (acomp) binding. > > The commit ade49db337a9 (ALSA: hda/hdmi - Allow audio component for > AMD/ATI and Nvidia HDMI) added the DRM audio component binding for > the NVIDIA codec drivers, but the traditional HD-audio unsolicited > event code path is still in use by the proprietary NVIDIA graphics > driver. > > This patch set adds DP-MST audio support for non-acomp codec drivers > which use the traditional HD-audio unsolicited event code path. This > patch set adds DP-MST support for NVIDIA codecs. > > The patch set has been tested for HDMI/DP-SST/DP-MST(4 dp-mst audio > streams) configurations on NVIDIA Kepler and Maxwell GPUs, using > both the nouveau driver and the proprietary NVIDIA graphics driver. Thanks for the patch. The logic looks good, but there are a few concerns in implementation details. Will comment in the reply of each patch. The timing is a bit late for merging into 5.5, though, for this kind of non-trivial changes. It'll be likely applied after 5.5 merge window, so for 5.6. Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel