From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62D72CA9EA0 for ; Fri, 18 Oct 2019 08:19:14 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD2C521D7C for ; Fri, 18 Oct 2019 08:19:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="tbvWGItm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD2C521D7C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D33CE852; Fri, 18 Oct 2019 10:18:21 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D33CE852 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1571386752; bh=SVPrOsqiXh5Xj0fl1iPUc++9hAvpyNv+9h7FaWXJebs=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=tbvWGItmc9ixrC4fqgk8xBsWtGKcrO87Uk3QHcL10bVl0W8ksVVlKyxHe79IrILxQ 0iDJQ4qMaV8w8Mc0Mpc6XVqg8/OsfV43QMWuCm051REiiPsA9YiinAUw/bxs5Oot24 THsIyutiIxA1s4FrH97Sg/atv2TS5ypJ6qRY5vrs= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 72D43F80323; Fri, 18 Oct 2019 10:18:21 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2D80DF80362; Fri, 18 Oct 2019 10:18:18 +0200 (CEST) Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 82B97F800D0 for ; Fri, 18 Oct 2019 10:18:15 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 82B97F800D0 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 3F37BB445; Fri, 18 Oct 2019 08:18:14 +0000 (UTC) Date: Fri, 18 Oct 2019 10:18:14 +0200 Message-ID: From: Takashi Iwai To: Kai-Heng Feng In-Reply-To: <20191018073848.14590-1-kai.heng.feng@canonical.com> References: <20191018073848.14590-1-kai.heng.feng@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Cc: bhelgaas@google.com, linux-pci@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [PATCH v6 1/2] PCI: Add a helper to check Power Resource Requirements _PR3 existence X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 18 Oct 2019 09:38:47 +0200, Kai-Heng Feng wrote: > > A driver may want to know the existence of _PR3, to choose different > runtime suspend behavior. A user will be add in next patch. > > This is mostly the same as nouveau_pr3_present(). > > Reported-by: kbuild test robot It's confusing -- this particular change isn't reported by the test bot, but only about the lack of the CONFIG_ACPI ifdef. thanks, Takashi > Signed-off-by: Kai-Heng Feng > --- > v6: > - Only define the function when CONFIG_ACPI is set. > v5: > - Add wording suggestion from Bjorn. > v4: > - Let caller to find its upstream port device. > > drivers/pci/pci.c | 18 ++++++++++++++++++ > include/linux/pci.h | 2 ++ > 2 files changed, 20 insertions(+) > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > index e7982af9a5d8..1df99d9e350e 100644 > --- a/drivers/pci/pci.c > +++ b/drivers/pci/pci.c > @@ -5856,6 +5856,24 @@ int pci_set_vga_state(struct pci_dev *dev, bool decode, > return 0; > } > > +#ifdef CONFIG_ACPI > +bool pci_pr3_present(struct pci_dev *pdev) > +{ > + struct acpi_device *adev; > + > + if (acpi_disabled) > + return false; > + > + adev = ACPI_COMPANION(&pdev->dev); > + if (!adev) > + return false; > + > + return adev->power.flags.power_resources && > + acpi_has_method(adev->handle, "_PR3"); > +} > +EXPORT_SYMBOL_GPL(pci_pr3_present); > +#endif > + > /** > * pci_add_dma_alias - Add a DMA devfn alias for a device > * @dev: the PCI device for which alias is added > diff --git a/include/linux/pci.h b/include/linux/pci.h > index f9088c89a534..1d15c5d49cdd 100644 > --- a/include/linux/pci.h > +++ b/include/linux/pci.h > @@ -2310,9 +2310,11 @@ struct irq_domain *pci_host_bridge_acpi_msi_domain(struct pci_bus *bus); > > void > pci_msi_register_fwnode_provider(struct fwnode_handle *(*fn)(struct device *)); > +bool pci_pr3_present(struct pci_dev *pdev); > #else > static inline struct irq_domain * > pci_host_bridge_acpi_msi_domain(struct pci_bus *bus) { return NULL; } > +static bool pci_pr3_present(struct pci_dev *pdev) { return false; } > #endif > > #ifdef CONFIG_EEH > -- > 2.17.1 > _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel